Feature/84849 & Feature/92930 accessibility fixes #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (2)
src/webchat-ui/components/history/ChatScroller.tsx:131
- Ensure that an element with the ID 'webchatChatHistoryHeading' exists in the DOM so that the aria-labelledby reference is properly resolved.
aria-labelledby="webchatChatHistoryHeading"
src/webchat-ui/components/Modal/Modal.tsx:53
- [nitpick] Verify that the absolute positioning and right offset of -4 for the CloseButton maintains an adequate clickable area across different devices.
position: "absolute", right: -4,
cypress/e2e/messageAvatar.cy.ts
Outdated
| @@ -103,7 +103,7 @@ describe("Bot message", () => { | |||
| cy.openWebchat().startConversation(); | |||
| cy.receiveMessage("bot message", {}, "bot"); | |||
|
|
|||
| cy.get('[alt="bot avatar"]').should( | |||
| cy.get('[data-testid="avatar"]').should( | |||
There was a problem hiding this comment.
The data-testid for the bot avatar is inconsistent with the other tests that use 'bot-avatar'; consider updating it for consistency.
Suggested change
| cy.get('[data-testid="avatar"]').should( | |
| cy.get('[data-testid="bot-avatar"]').should( |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
|
The tests will fail until I update chat-components to a newer version. I will update the chat-components once Cognigy/chat-components#118 is merged |
vj-venkatesan
previously approved these changes
Apr 10, 2025
sushmi21
changed the title
vj-venkatesan
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Success criteria
Please describe what should be possible after this change. List all individual items on a separate line.
Aria-labelledby is added to element with role="log"(Adding a label is making the message announcements very verbose with NVDA, as the label is announced with every sent or received message). Redundant aria-live="polite" is removedHow to test
Please describe the individual steps on how a peer can test your change.
Security
Additional considerations
Documentation Considerations
These are hints for the documentation team to help write the docs.