Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SkepticBreaker Implementation #43

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

SkepticBreaker Implementation #43

wants to merge 4 commits into from

Conversation

ekmason12
Copy link

Implemented SkepticBreaker, refactored code between CircuitBreaker and SkepticBreaker, added SkepticBreaker example

*/
public void increaseSkepticLevel() {
skepticLevel.set(skepticLevel.incrementAndGet());
updateTimers();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why wouldn't I have this call immediately follow the increaseSkepticLevel() call in the method above inside the if block? It seems like an unexpected result to have a call to something called increaseSkepticLevel be also updating timers.

@joercampbell
Copy link
Collaborator

It would be really cool if there were also a markdown document or wiki page to go along with this describing the functionality and how the skeptic breaker will react to things. :) I like what you have here though. I am working with my other buddy @weggert around the path to take to merge and get this into a producable state.

@CLAassistant
Copy link

CLAassistant commented Jul 22, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ bvand
❌ ekmason12
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants