Revert "Restrict applyToGraph to PrimitiveNode" (#2677)

Comfy-Org · Feb 22, 2025 · f43eac7 · f43eac7
1 parent d7c9a43
commit f43eac7
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/src/nodes/PrimitiveNode.ts b/src/nodes/PrimitiveNode.ts
@@ -569,7 +569,7 @@ export function isValidCombo(combo: string[], obj: unknown) {
   return true
 }
 
-export function isPrimitiveNode(node: LGraphNode): node is PrimitiveNode {
+function isPrimitiveNode(node: LGraphNode): node is PrimitiveNode {
   return node.type === 'PrimitiveNode'
 }
 

diff --git a/src/types/litegraph-augmentation.d.ts b/src/types/litegraph-augmentation.d.ts
@@ -73,6 +73,7 @@ declare module '@comfyorg/litegraph' {
     convertToNodes?(): LGraphNode[]
     recreate?(): Promise<LGraphNode>
     refreshComboInNode?(defs: Record<string, ComfyNodeDef>)
+    applyToGraph?(extraLinks?: LLink[]): void
     updateLink?(link: LLink): LLink | null
     onExecutionStart?(): unknown
     /**

diff --git a/src/utils/executionUtil.ts b/src/utils/executionUtil.ts
@@ -1,7 +1,6 @@
 import type { LGraph } from '@comfyorg/litegraph'
 import { LGraphEventMode } from '@comfyorg/litegraph'
 
-import { isPrimitiveNode } from '@/nodes/PrimitiveNode'
 import type { ComfyApiWorkflow, ComfyWorkflowJSON } from '@/types/comfyWorkflow'
 
 /**
@@ -20,8 +19,11 @@ export const graphToPrompt = async (
       ? outerNode.getInnerNodes()
       : [outerNode]
     for (const node of innerNodes) {
-      if (isPrimitiveNode(node)) {
-        node.applyToGraph()
+      if (node.isVirtualNode) {
+        // Don't serialize frontend only nodes but let them make changes
+        if (node.applyToGraph) {
+          node.applyToGraph()
+        }
       }
     }
   }