Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Move Widget.beforeQueued invocation from graphToPrompt to queuePrompt #2667

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

huchenlei
Copy link
Member

@huchenlei huchenlei commented Feb 21, 2025

graphToPrompt should not side effect on triggering beforeQueued on widgets. This PR moves the invocation to queuePrompt which matches the invocation site of afterQueued.

┆Issue is synchronized with this Notion page by Unito

@huchenlei huchenlei requested a review from a team as a code owner February 21, 2025 19:07
@huchenlei huchenlei merged commit 40da438 into main Feb 21, 2025
10 checks passed
@huchenlei huchenlei deleted the move_hooks branch February 21, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant