-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/knob #2701
base: main
Are you sure you want to change the base?
Feature/knob #2701
Conversation
@@ -91,6 +92,8 @@ function getFormComponent(item: FormItem): Component { | |||
return InputNumber | |||
case 'slider': | |||
return InputSlider | |||
case 'knob': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you changed the wrong thing here. The FormItem
is for settings dialog content mainly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you changed the wrong thing here. The
FormItem
is for settings dialog content mainly.
Should I remove it? I do not see the harm in having the option.
Realized late merge is not allowed will fix tomorrow. |
Regarding the following:
where are these declared? as I think in this case knob should be in the second list. |
|
So In theory Comfy-Org/litegraph.js#600 would have to be merge for this to pass? |
Added the VUE knob, as an exploration on how to add knobs to the UI itself, I mistook the front-end and the litegraph part, ended up adding the VUE knob to front-end. Might come in handy or just a different flavor of a slider in some menus.
┆Issue is synchronized with this Notion page by Unito