Skip to content

Remove automatic nightly pytorch for blackwell users on desktop #3613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 25, 2025

Conversation

benceruleanlu
Copy link
Collaborator

@benceruleanlu benceruleanlu commented Apr 24, 2025

Truly, a tear is to be shed.

We no longer need to force nightly on blackwell users.

TorchMirrorUrl.NightlyCuda, however, lives on.

┆Issue is synchronized with this Notion page by Unito

@benceruleanlu benceruleanlu requested a review from a team as a code owner April 24, 2025 22:37
@benceruleanlu benceruleanlu marked this pull request as draft April 24, 2025 22:37
@benceruleanlu
Copy link
Collaborator Author

Waiting for types publish from Comfy-Org/desktop#1126.

@benceruleanlu benceruleanlu changed the title Remove forced nightly for desktop Remove automatic nightly pytorch for blackwell users on desktop Apr 25, 2025
@benceruleanlu
Copy link
Collaborator Author

Types are published!

@benceruleanlu benceruleanlu marked this pull request as ready for review April 25, 2025 21:45
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​comfyorg/​comfyui-electron-types@​0.4.39 ⏵ 0.4.4277 +21006695 +170

View full report

@benceruleanlu benceruleanlu merged commit 84c14dd into main Apr 25, 2025
10 checks passed
@benceruleanlu benceruleanlu deleted the bcl1 branch April 25, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants