fix: multiple typos of different value #1063
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DeVikingMark is attempting to deploy a commit to the Consensys Team on Vercel. A member of the Team first needs to authorize it. |
jlwllmr
requested changes
Apr 17, 2025
README.mdx
Outdated
| @@ -237,5 +237,5 @@ As outlined above, you can adjust the display size of the svg by changing the cl | |||
|
|
|||
| ### Social cards | |||
|
|
|||
| A social card for any new article(s) will be generated and applied when the site builds, so there | |||
| A social card for any new article(s) will be generated and applied when the site is built so there | |||
There was a problem hiding this comment.
Disagree, we often use build in the active voice in this context — could you revert please
docs/api/linea-sdk.mdx
Outdated
|
|
||
| :::info[New Features] | ||
|
|
||
| The updated Linea SDK package enhances the L1 contract interaction and adds support for the new L1 claiming system, which is based on a Merkle tree and requires a Merkle proof for claiming. | ||
| The updated Linea SDK package enhances the L1 contract interaction and adds support for the new L1 claiming system, which is based on a Merkle tree and requires Merkle proof for claiming. |
There was a problem hiding this comment.
Not sure why you removed the article here? Please revert
docs/api/linea-sdk.mdx
Outdated
| @@ -40,7 +40,7 @@ The updated SDK introduces several new features for L1 interactions: | |||
| A new L1ClaimingService class that includes the following functions: | |||
|
|
|||
| - getMessageProof: This function retrieves the message Merkle tree proof required for new message claims on L1. | |||
| - isClaimingNeedingProof: This function determines whether a proof is needed to claim a message. | |||
| - isClaimingNeedingProof: This function determines whether proof is needed to claim a message. | |||
There was a problem hiding this comment.
Again, please revert, proof is not an abstract noun here
docs/release-notes.mdx
Outdated
| @@ -82,7 +82,7 @@ for any required pauses. Many of the contract modifications have also resulted i | |||
| Additionally, we are removing the `finalizeBlocksWithoutProof` function, and adding functionality | |||
| that enables any address to send blob submission and finalization transactions through a call | |||
| forwarding contract if no finalization occurs for more than six months. This effectively allows L1 | |||
| finalization, enabling withdrawal of potentially locked funds. | |||
| finalization, enabling the withdrawal of potentially locked funds. | |||
There was a problem hiding this comment.
I think this is unnecessary, please revert
docs/release-notes.mdx
Outdated
| @@ -208,7 +208,7 @@ mode. | |||
|
|
|||
| Adds support for Linea Names domains, including a frontend app for users to register and manage their | |||
| domains. The Linea Names system is comparable to ENS on Ethereum Mainnet, except that domains are | |||
| limited to one per account and registering requires completion of [Proof of Humanity](https://poh.linea.build/). | |||
| limited to one per account, and registering requires completion of [Proof of Humanity](https://poh.linea.build/). | |||
There was a problem hiding this comment.
unnecessary change — please revert
docs/release-notes.mdx
Outdated
| @@ -337,7 +337,7 @@ can be significantly cheaper in L1 ETH costs depending on market demand. | |||
|
|
|||
| EIP-4844's arrival on Ethereum Mainnet enabled Ethereum L2s to start using a new transaction type | |||
| that transports L2 transaction and messaging data to L1 in "blobs". Blobs are a considerably | |||
| more cost-efficient alternative to the existing method of posting L2 transaction and messaging data | |||
| more cost-efficient alternative to the existing method of posting L2 transactions and messaging data | |||
There was a problem hiding this comment.
Incorrect, changes intended meaning. Please revert
docs/release-notes.mdx
Outdated
| @@ -577,7 +577,7 @@ be replaced by the `DataFinalized` event. | |||
| <code>DataFinalized</code> | |||
| </td> | |||
| <td> | |||
| Emitted at the end of finalization - used to indicate range of | |||
| Emitted at the end of finalization - used to indicate a range of | |||
Co-authored-by: Joel Willmore <95916148+jlwllmr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Team! Just made lots of typos fixes and changed some wording in .mdx files.