Skip to content

[Chore] Remove betaV1 tests #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 9, 2025
Merged

Conversation

thedarkjester
Copy link
Collaborator

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.72%. Comparing base (47a9d07) to head (cab3d6a).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #905      +/-   ##
============================================
- Coverage     66.74%   66.72%   -0.02%     
  Complexity     1132     1132              
============================================
  Files           322      322              
  Lines         12972    12972              
  Branches       1353     1353              
============================================
- Hits           8658     8656       -2     
- Misses         3750     3752       +2     
  Partials        564      564              
Flag Coverage Δ *Carryforward flag
hardhat 98.53% <ø> (-0.21%) ⬇️
kotlin 64.20% <ø> (ø) Carriedforward from 47a9d07

*This pull request uses carry forward flags. Click here to find out more.

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fluentcrafter
Copy link
Contributor

@thedarkjester shall we merge this?

@thedarkjester thedarkjester marked this pull request as ready for review May 9, 2025 11:57
@thedarkjester thedarkjester requested a review from a team as a code owner May 9, 2025 11:57
@thedarkjester thedarkjester changed the title [Chore] Remove betaV1 tests - DO NOT MERGE UNTIL v1.4 is released [Chore] Remove betaV1 tests May 9, 2025
@thedarkjester
Copy link
Collaborator Author

@thedarkjester shall we merge this?

yeah, just brought main and in and made it active for review

@thedarkjester thedarkjester merged commit 72a15de into main May 9, 2025
19 checks passed
@thedarkjester thedarkjester deleted the chore/remove-older-betaV1-tests branch May 9, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants