Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add back missing translation for wallet-ui #512

Merged
merged 6 commits into from
Feb 15, 2025

Conversation

khanti42
Copy link
Collaborator

@khanti42 khanti42 commented Feb 13, 2025

This PR is to fix the missing translation from UI that cause by dynamic transaction name from getTxnName

@khanti42 khanti42 requested a review from a team as a code owner February 13, 2025 12:00
@khanti42 khanti42 requested review from Julink-eth and wantedsystem and removed request for a team February 13, 2025 12:00
@khanti42 khanti42 force-pushed the chore/missing-translation branch from 3d85fd4 to 9a3b4e1 Compare February 13, 2025 12:02
Copy link
Collaborator

@stanleyyconsensys stanleyyconsensys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 comments

Copy link

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link
Collaborator

@stanleyyconsensys stanleyyconsensys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stanleyyconsensys stanleyyconsensys added this pull request to the merge queue Feb 15, 2025
Merged via the queue into main with commit 9b09d7e Feb 15, 2025
15 checks passed
@stanleyyconsensys stanleyyconsensys deleted the chore/missing-translation branch February 15, 2025 11:41
@stanleyyconsensys stanleyyconsensys changed the title chore: add missing translation chore: add back missing translation for wallet-ui Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants