Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated GetBlockV2 from Validator API #8490

Closed
wants to merge 2 commits into from

Conversation

gfukushima
Copy link
Contributor

@gfukushima gfukushima commented Aug 1, 2024

PR Description

This PR removes the GetBlockV2 from the Validator API. A follow-up PR will promote V3 to be the default.

Fixed Issue(s)

Part of #7779

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR removes the deprecated GetBlockV2 from the Validator API, paving the way for GetBlockV3 to become the default.

  • Removed /data/beaconrestapi/src/main/java/tech/pegasys/teku/beaconrestapi/handlers/v2/validator/GetNewBlock.java to eliminate the V2 endpoint.
  • Deleted /data/beaconrestapi/src/test/java/tech/pegasys/teku/beaconrestapi/handlers/v2/validator/GetNewBlockV2Test.java to remove tests for the deprecated V2 API.
  • Updated /data/beaconrestapi/src/main/java/tech/pegasys/teku/beaconrestapi/JsonTypeDefinitionBeaconRestApi.java to remove references to the V2 endpoint.
  • Removed /data/beaconrestapi/src/integration-test/java/tech/pegasys/teku/beaconrestapi/v1/validator/GetNewBlockIntegrationTest.java as V2 tests are no longer needed.
  • Updated CHANGELOG.md to document the removal of the deprecated GetBlockV2 endpoint.

5 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@gfukushima
Copy link
Contributor Author

gfukushima commented Aug 1, 2024

Closing this for now as the plans have changed, we want to enable V3 by default before removing V2

@gfukushima gfukushima closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant