Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote GetNewBlockV3 and enable by default #8493

Merged
merged 7 commits into from
Aug 6, 2024

Conversation

gfukushima
Copy link
Contributor

PR Description

This PR unhides the GetNewBlockV3 and enables it by default.

Fixed Issue(s)

Part of #7779

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

The PR promotes the GetNewBlockV3 API and enables it by default.

  • CHANGELOG.md: Updated to reflect the promotion of the GetNewBlockV3 API to default.
  • teku/src/main/java/tech/pegasys/teku/cli/options/ValidatorOptions.java: Un-hid --block-v3-enabled and set it to default true.
  • validator/api/src/main/java/tech/pegasys/teku/validator/api/ValidatorConfig.java: Set DEFAULT_BLOCK_V3_ENABLED to true.

These changes align with the goal of making the Block V3 API the default for block production.

3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@gfukushima gfukushima enabled auto-merge (squash) August 2, 2024 06:35
Copy link
Contributor

@tbenr tbenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know if we really want to expose the --block-v3-enabled.. if we do that we theoretically add it in docs and it will be a problem when we deprecate the option completely (cose it will be a breaking change). I might be wrong, just posing the questions :)

@gfukushima
Copy link
Contributor Author

Make sense to me, I'll keep it as experimental them.

@@ -139,10 +139,9 @@ public class ValidatorOptions {
private int executorThreads = DEFAULT_VALIDATOR_EXECUTOR_THREADS;

@Option(
names = {"--Xblock-v3-enabled"},
names = {"--block-v3-enabled"},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think leaving it as a dev option thats just enabled by default was what i was thinking, i am hoping that this flag disappears once we prove we don't require it...

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
@gfukushima gfukushima merged commit 777c9dc into Consensys:master Aug 6, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants