Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated GetNewBlindedBlock #8508

Merged
merged 3 commits into from
Aug 12, 2024

Conversation

gfukushima
Copy link
Contributor

PR Description

Remove deprecated GetNewBlindedBlock from validator API now that we've enabled GetNewBlockV3

Fixed Issue(s)

Part of #7779

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
@gfukushima gfukushima force-pushed the remove-blinded_blocks branch from 9cb4ee3 to d623441 Compare August 12, 2024 05:15
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

The pull request removes the deprecated GetNewBlindedBlock handler and its associated tests, transitioning to the GetNewBlockV3 API.

  • Removed data/beaconrestapi/src/main/java/tech/pegasys/teku/beaconrestapi/handlers/v1/validator/GetNewBlindedBlock.java
  • Removed data/beaconrestapi/src/test/java/tech/pegasys/teku/beaconrestapi/handlers/v1/validator/GetNewBlindedBlockTest.java
  • Removed data/beaconrestapi/src/integration-test/java/tech/pegasys/teku/beaconrestapi/v1/validator/GetNewBlockIntegrationTest.java
  • Updated data/beaconrestapi/src/main/java/tech/pegasys/teku/beaconrestapi/JsonTypeDefinitionBeaconRestApi.java to remove GetNewBlindedBlock references
  • Updated CHANGELOG.md to document the removal of the deprecated GetBlindedBlock endpoint

These changes streamline the codebase and ensure the latest API version is used consistently.

5 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link
Contributor

@rolfyone rolfyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once integration tests pass (will need OpenApiIntegrationTest updated)

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
@gfukushima gfukushima merged commit 07c2b0c into Consensys:master Aug 12, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants