Get proposer head #9134
Merged
Get proposer head #9134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
| @@ -182,6 +182,10 @@ public Bytes32 getProposerHead(final Bytes32 headRoot, final UInt64 slot) { | |||
| LOG.debug("getProposerHead - return parentRoot - isHeadWeak true && isParentStrong true"); | |||
| return head.getParentRoot(); | |||
| } | |||
| if (!getStore().satisfiesInclusionList(headRoot)) { | |||
There was a problem hiding this comment.
Not sure about adding the IL check at this stage since we might end up never reaching this block.
The new spec states:
reorg_prerequisites = all([shuffling_stable, ffg_competitive, finalization_ok,
proposing_on_time, single_slot_reorg, head_weak, parent_strong])
# Check that the head block is in the unsatisfied inclusion list blocks
inclusion_list_not_satisfied = head_root in store.unsatisfied_inclusion_list_blocks # [New in EIP-7805]
if reorg_prerequisites and (head_late or inclusion_list_not_satisfied):
return parent_root
else:
return head_rootSo IMU the inclusion_list_not_satisfied should be taken into consideration in the other checks reorg_prerequisites
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Modifies get_proposer_head to include the inclusion list validation.
Fixed Issue(s)
Fixes #9099
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog