-
Notifications
You must be signed in to change notification settings - Fork 54
Decision Proposal 048 - Draft Standards Feedback Cycle 4 #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi James, A couple of small points/clarifications this week.
|
Hi @anzbankau, responses below:
Hope that helps, if any of the above doesn't make sense let me know. -JB- |
Hi James, This trips up some strict validators. I base the correct format from https://json-schema.org/understanding-json-schema/reference/numeric.html "ParamPage": {
"name": "page",
"in": "query",
"description": "Page of results to request (standard pagination)",
"required": false,
"type": "integer",
"default": "1"
},
"ParamPageSize": {
"name": "page-size",
"in": "query",
"description": "Page size to request. Default is 25 (standard pagination)",
"required": false,
"type": "integer",
"default": "25"
}
"isOwned": {
"type": "boolean",
"description": "Flag indicating that the customer associated with the authorisation is an owner of the account. Does not indicate sole ownership, however. If no present then 'true' is assumed",
"default": "true"
} jf |
Thanks for picking that up @jnflint. All reviews are welcome. Feedback is judged on merit, not source of origin. I will add these changes to the backlog of minor corrections to be made. -JB- |
James, |
Hi @anzbankau, the EXIT type would apply to both types of fees (early exit and normal maturity). The difference can be expressed in other fields such as the name or additionalInfo. If this type were implied to be only early exit then there would be no type for normal closure. -JB- |
For those that may not have noticed I have now updated product reference with recommendations regarding product fees/discounts and rate tiering. I will be completing the remainder of the recommendations on product reference shortly. I suggest that feedback for product reference be moved to this thread. -JB- |
For the product reference changes for fees/discounts and rate tiers I deviated from the ABA recommendation as follows as a result of converting the recommendations to swagger:
-JB- |
James, |
A tier name and sub-tier name are good additions. I will add these in. -JB- |
James, Option 2 in the ABA proposal used a nested structure, but it had rates within the nesting so that they were associated with all the necessary ‘criteria’. However option 1 was proposed because it ‘flattened’ the multi-dimensional model based upon the rate (much like a fact table in a dimensional model) to preserve the simple ‘array-of-rates’ structure that supports most rates. |
This could have been my misinterpretation of the ABA proposal. It was unclear if the tier object was intended to be plural or not. If the feedback is to change tiers from array to singleton then I’m happy to do that. Is that what you are recommending Rod? -JB- |
I have made the above change and also updated the product category enumeration values as per the ABA recommendations. I believe that all feedback for product reference is now incorporated into the standard. I would appreciate a review as to whether any items were missed or if further changes were made. -JB- |
Hi James, some product related questions we have for GET /banking/accounts/{accountId}
Thanks |
Hi James, one more - this time on Transaction end points
Thanks |
Re: Proposal for Product Reference API for Rate Tiers within Deposit and Lending Rates The ABA proposal (and selection of option 1) was guided by not making too much of a change but since James suggested tier arrays, I incorporated them in a revision of the proposal with a TierSet type to support aspects of the structure in option 2. The following is a stripped-down, compressed format of the proposed schema and examples to make it easier to appreciate ‘tierSet’ examples (also in a vain attempt to fit it into a post). If this is acceptable a tabular specification (update to previous document) will follow. Schema (Non-elementary types are of the form :{}. Enumerations Example: Transaction and Savings Example: Term Deposits Note: Key tier discriminator is applicationFrequency For the full post see the attached document. |
SummaryNAB welcomes the opportunity to continue to provide feedback to this cycle of the draft CDR standards. Our response will primarily focus on the ProductProduct - GeneralProduct categories have not been updated throughout the whole standard. It is now in the response messages in all the get messages which still include the old product categories. Product - EligibilityAs per feedback to #39, we recommend the inclusion of another enumerated value for Product - Fees
Product - Rates
|
Hi James, For the transaction filters, we understand there is the following pending update: Get Transactions end-time description will be amended to say “minus” 90 days. Based on feedback from commbankoss the 100 days will be changed to 90 days to approximately match 3 months. However based on this the current description of end-time being 'effective time at or before this date/time' would also need to be updated to say 'effective time at or after this date/time'. Or the default conditions could be switched so that start-time is earlier than end-time. Thanks. |
Decision Proposal 048 - Draft Standards Feedback Cycle 4 In the Product Detail API, we would like to see the addition of the following enumerated values to the BankingProductFeature.featureType field:
|
James, |
Hi All, some response to the minor queries since the last response: Syncing Account Payload Active vs Available Account Data Accuracy
Consent To Transaction Extent Clarification Over Previous Feedback -JB- |
Response to additional Product Reference feedback is below. Before providing the feedback, however, I would note that this will likely conclude the feedback taken on Product Reference. The feedback is beginning to become circular with requests for changes followed by requests to reverse those changes. We are also starting to get to the point of diminished returns. After this round of feedback I intend to produce a final decision document setting in place v1 of the schema. Natural Person Eligibility Fee Types Rates As Enum Fee Floor Discount To Fee discountEligibilityType Discount Rate Types Lending Rate Types Agree that INTRODUCTORY, DISCOUNT, BUNDLE_DISCOUNT_FIXED are variations that could be captured in additionalInfo but these are variations that would be useful to have in structured form based on previous feedback so I will not remove them Will include comparisonRate and remove COMPARISON_FIXED and COMPARISON_VARIABLE Will change the paymentStructureType field to interestPaymentDue Will make tier an array again as this would appear to make this more expressive and address the areas of concern. Where the additional expressiveness is not required an array with a single element would be fine Feature Types I will add a dicount feature type for things such as discount gift cards, discount travel, etc. This will be called COMPLEMENTARY_PRODUCT_DISCOUNTS to avoid confusion with fee discounts BONUS_REWARDS will be added show how many bonus reward points are given for switching to a product A NOTIFICATIONS feature will be added to describe enhanced notifications capability. The more generic name (rather than the suggested BALANCE_NOTIFICATIONS) will allow coverage of notifications for wider range of events An OTHER feature type will be added -JB- |
Regarding the remaining feedback on Accounts: Balances
There is a fine line between “oversight” and “haven’t got to it yet” but it is appreciated that this has been raised. repaymentType & loanPurpose Rate Tiers Simplified Balance Minor Changes -JB- |
I will be closing out this feedback thread tomorrow (Friday 7th) and opening a new thread. -JB- |
James, |
Decision Proposal 048 - Draft Standards Feedback Cycle 4 Regarding the Product API, we agree with previous feedback on the need for the enumerated value of ‘Other’ as the current list does not currently describe the vast number of features that can be associated with different Credit Cards. Such benefits are important for the comparison of products that will best suit a customer’s needs. Ideally further consideration could be given to ways to describe key feature attributes instead of having to rely heavily on the additionalValue field (free format string). For example consider optional and common fields like - Feature Name, Loyalty Points Earn Rate, Eligibility, Value, Frequency etc. |
Account AddressesPreviously, we have communicated our concern about the leakage of account addresses outside of the customer security scope and recommended that the BankingAccountDetail.address field is removed. An account may have more than one address associated with it. These may not be explicitly marked for correspondence, and we don’t always store a shared address. These addresses may be those of third parties who haven’t consented to have their data shared. We may not always be aware that an address is an address of a third party. Aside from the privacy issues, an outcome where sensitive information or perhaps a new credit card is accidentally mailed to third parties by data consumers is undesirable. For these reasons, we re-iterate our concerns and would appreciate guidance on the handling of the scenarios mentioned if the field is to remain. This concern has also been recently been reinforced by the (research) flow prototypes published by Data61 in the CX Report. These prototypes did not present this detail prominently. Additionally, it was indicated that the tested permission language “Account mail address” was not easily understood by research participants. URI StructureWe have also posted following feedback to the security working group issue register. The draft technical standard specifies a
Issues related to currency
Questions and comments related to the representation of product dataWe have the following queries and comments in relation to the representation of products:
Other feedback and questionsWe also have some minor feedback and questions. Many of these points are related to the product endpoints:
|
James, You must be sick of this topic, but the following suggested additions don’t go over old ground (as far as we can tell), but would provide consistency to assist payload consumers:
The last item would require Mandatory fields with arrays that state the array may be empty to be made Optional so that it better reflects the intent at the schema level (where it is obvious) rather than embedding the optionality rule in the description. I'm sure we're all scanning the Required column (or filtering a spreadsheet using it) only to get tripped up by |
I left this thread open a little longer by request for a few final comments to be submitted. I have now locked the thread and will respond to the final comments above. Following that I will open Feedback Cycle 5. -JB- |
@anzbankau. Synchronisation of the descriptions of the masked types is in my backlog. As per the feedback to issue #39 I will be making both of the types to describe the showing of 4 digits. -JB- |
@AmexAUopenbanking. There has been significant discussion around the granularity of feature types and feedback from the community has been conflicting with some participants arguing for low resolution categories and some arguing for high resolution, specific, types. The current position (which, of course, can be modified at a later date via the versioning strategy) is a compromise level of granularity with the expectation that This will be the position for v1 of Product Reference. -JB- |
@anzbankau. Regarding optionality, I will take your suggestion that the representation of optionality in the standards isn’t complete and will extend it based on previously stated positions in GitHub. -JB- |
Feedback in response to @WestpacOpenBanking. Some of this is a reiteration of product reference feedback already supplied so I will attempt to maintain consistency in response. Account Addresses In regard to CX language findings, it is definitely the case that the difference between an Account level address and Customer level address has been something that needs to be dealt with in the language presented during consent. The CX stream are seeking feedback on this, and other topics, via Medium. URI Structure Currency Product Reference
Other Feedback -JB- |
Uh oh!
There was an error while loading. Please reload this page.
This issue has been opened to capture feedback on the standards as a whole. The standards site will be incrementally updated to accommodate this feedback. This is the fourth cycle of holistic feedback for the standards.
-JB-
The text was updated successfully, but these errors were encountered: