Skip to content

chore: Use prefix-based routing for IBCv2 contracts #2258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 13, 2025

Conversation

kulikthebird
Copy link
Contributor

@kulikthebird kulikthebird commented May 14, 2025

closes #2278

@kulikthebird kulikthebird linked an issue May 14, 2025 that may be closed by this pull request
@kulikthebird kulikthebird force-pushed the tkulik/chore/ibc2_port_router branch 2 times, most recently from 4399c2c to 47cf38f Compare May 20, 2025 17:27
@kulikthebird kulikthebird force-pushed the tkulik/chore/ibc2_port_router branch from 47cf38f to cfdf78c Compare May 22, 2025 16:28
@kulikthebird kulikthebird linked an issue May 28, 2025 that may be closed by this pull request
@kulikthebird kulikthebird force-pushed the tkulik/chore/ibc2_port_router branch from cfdf78c to 40437f8 Compare May 29, 2025 09:49
@kulikthebird kulikthebird changed the base branch from main to tkulik/feat/register_ibc2_contracts May 29, 2025 09:49
@kulikthebird kulikthebird force-pushed the tkulik/feat/register_ibc2_contracts branch from 7f3d719 to d2a1e80 Compare May 30, 2025 10:30
@kulikthebird kulikthebird force-pushed the tkulik/chore/ibc2_port_router branch from 40437f8 to aa74e2b Compare May 30, 2025 13:01
@chipshort chipshort self-assigned this Jun 13, 2025
@chipshort chipshort force-pushed the tkulik/chore/ibc2_port_router branch from aa74e2b to 1f17348 Compare June 13, 2025 10:39
@chipshort chipshort changed the base branch from tkulik/feat/register_ibc2_contracts to main June 13, 2025 10:39
@chipshort chipshort marked this pull request as ready for review June 13, 2025 10:39
@chipshort chipshort force-pushed the tkulik/chore/ibc2_port_router branch from 1f17348 to baaa260 Compare June 13, 2025 11:00
@chipshort chipshort requested a review from pinosu June 13, 2025 11:11
Copy link

codecov bot commented Jun 13, 2025

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Project coverage is 44.95%. Comparing base (008e4f5) to head (baaa260).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
tests/wasmibctesting/utils.go 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2258      +/-   ##
==========================================
+ Coverage   44.92%   44.95%   +0.03%     
==========================================
  Files          80       80              
  Lines       11034    11010      -24     
==========================================
- Hits         4957     4950       -7     
+ Misses       5641     5623      -18     
- Partials      436      437       +1     
Files with missing lines Coverage Δ
app/app.go 86.59% <100.00%> (ø)
x/wasm/keeper/ibc.go 100.00% <100.00%> (ø)
x/wasm/keeper/keeper.go 78.16% <100.00%> (-0.11%) ⬇️
x/wasm/keeper/keeper_cgo.go 95.34% <100.00%> (ø)
tests/wasmibctesting/utils.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! LGTM 💯

@pinosu pinosu merged commit 9091173 into main Jun 13, 2025
19 checks passed
@pinosu pinosu deleted the tkulik/chore/ibc2_port_router branch June 13, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: IBCv2 prefix-based port routing
3 participants