Adds packager cycle config #8577
Conversation
| @@ -76,7 +78,7 @@ public class PackagerBlockEntity extends SmartBlockEntity { | |||
| public PackagerItemHandler inventory; | |||
| private final LazyOptional<IItemHandler> invProvider; | |||
|
|
|||
| public static final int CYCLE = 20; | |||
| public static final int CYCLE = AllConfigs.server().logistics.packagePackCycle.get(); | |||
There was a problem hiding this comment.
This config value is only applied after the game is reloaded, when used this way.
There was a problem hiding this comment.
CYCLE is also used outside PackagerBlockEntity.java, which this PR doesn't account for.
| @@ -9,6 +9,7 @@ public class CLogistics extends ConfigBase { | |||
| public final ConfigInt psiTimeout = i(60, 1, "psiTimeout", Comments.psiTimeout); | |||
| public final ConfigInt mechanicalArmRange = i(5, 1, "mechanicalArmRange", Comments.mechanicalArmRange); | |||
| public final ConfigInt packagePortRange = i(5, 1, "packagePortRange", Comments.packagePortRange); | |||
| public final ConfigInt packagePackCycle = i(20, 0, "packagePackCycle", Comments.packagePackCycle); | |||
There was a problem hiding this comment.
Low enough values here will cause the package to always be invisible, or the tray to not move. (see animationTicks) (the animation looks fine (though slower) with higher values)
There was a problem hiding this comment.
I do apologise as this is my first ever PR, do you need me to fix these issues and remake the PR?
There was a problem hiding this comment.
You can create additional commits & push those on the branch you used for this, it'll get added to the PR automatically.
There was a problem hiding this comment.
Thank you, issues resolved:
- changed minimum cycle ticks to make sure animation gets played
- fixed config to actually work on reload
Potential changes needed:
Separate configs so re-packager can have its own cycle config time?
VoidLeech
added
pr type: feature
Adds a config for packager cycle config, allowing packager packing time to be controlled. I added this as I believe that some aspects of factories can be bottlenecked by a single packager having to export large amounts of a single resource. Added as a config to keep balance for those who want to keep the vanilla feel.