Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: differential slippage values for L2 networks #3462

Open
emilydrakesmith opened this issue Feb 29, 2024 · 0 comments
Open

[Enhancement]: differential slippage values for L2 networks #3462

emilydrakesmith opened this issue Feb 29, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request high-prio L2

Comments

@emilydrakesmith
Copy link
Contributor

Requirements

The app currently consumes and persists the slippage values specific to the transaction type (swap/mint/reposition) and token pair type (stable/volatile). We need to add a layer of differential handling for L1 vs L2 networks.

Specific goals:

  • Add a new default slippage value of 1 to be consumed when the user is connected to an L2 network.
  • Slippage presets should be updated similarly to sensible options relative to this default.
  • We do not need separate slippage values for transaction type or token pair type on L2 networks.
  • The L2 slippage value should be persisted in local storage separately from the L1 slippage values.
  • All logic should be managed in the data layer with no changes to the presentation layer.

Figma

No response

Assumptions

No response

@emilydrakesmith emilydrakesmith self-assigned this Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request high-prio L2
Projects
None yet
Development

No branches or pull requests

1 participant