Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change LastRowRef on TableRows according to new client side filtering #4824

Merged

Conversation

raltunel
Copy link
Contributor

@raltunel raltunel commented Mar 12, 2025

Describe your changes

Ref used in InfiniteScroll addMoreData method to check if fix monad issue
LastRowRef assignment has been changed for last changes

Link the related issue

Closes #0000

Checklist before requesting a review

  • Is this PR ready for merge? (Please convert to a draft PR otherwise)
  • I have performed a self-review of my code.
  • Did I request feedback from a team member prior to the merge?
  • Does my code following the style guide at docs/CODING-STYLE.md?

Instructions for Reviewers

Functionalities or workflows that should specifically be tested.

Environmental conditions that may result in expected but differential behavior.

If relevant, list additional work to complete pre-merge (delete logging, code abstraction, etc)

Copy link

netlify bot commented Mar 12, 2025

👷 Deploy request for futa-finance pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit be9dee5

Copy link

netlify bot commented Mar 12, 2025

Deploy Preview for dev-ambi ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/dev-ambi/deploys/67d1cbbef997c200be7e1854
😎 Deploy Preview https://deploy-preview-4824--dev-ambi.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 12, 2025

Deploy Preview for monad-ambient-finance ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/monad-ambient-finance/deploys/67d1cbb28c27a3008ca03acd
😎 Deploy Preview https://deploy-preview-4824--monad-ambient-finance.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@benwolski benwolski marked this pull request as draft March 12, 2025 13:52
@raltunel raltunel changed the title Adding ref usage into InfiniteScroll, shortcut key for debugger Change LastRowRef on TableRows according to new client side filtering Mar 12, 2025
@raltunel raltunel marked this pull request as ready for review March 12, 2025 15:25
Copy link
Collaborator

@benwolski benwolski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

infinite scroll appears to be fixed on the transactions table again!

@benwolski benwolski merged commit 6b9d15f into CrocSwap:develop Mar 12, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants