Cherrypick out linter #113
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Viktor Petersson <self@vpetersson.com>
|
@vpetersson - any reason you have chosen not to use an existing GitHub Action for this? |
|
@madpah I've found Super Linter to be super slow (and bloated) in the past. I just copied this from other pipelines where I've added this setup. We could definitely add an upstream Action, but it was just a few lines so i figured it was easier to implement. However, if you feel strongly that we should use an existing action, I can change it. |
|
No strong opinion - just having the chat 😉 |
|
All good, mate! Yeah I usually try to use (well maintained) Action modules too, but haven't found a good one for this. Also, note that the tests are failing because I didn't run it. @oej asked me to not apply the linting in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick out Markdown linter without actually running it.