Skip to content

Commit

Permalink
cli/reportgen
Browse files Browse the repository at this point in the history
  • Loading branch information
TilakMaddy committed Jul 31, 2024
1 parent cd83467 commit d03d555
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 9 deletions.
6 changes: 3 additions & 3 deletions aderyn_core/src/detect/high/high_level_calls_in_loop.rs
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,9 @@ impl IssueDetector for HighLevelCallsInLoopDetector {
}

fn description(&self) -> String {
String::from("One of the dangers of having high level calls or an `address.transfer()` inside a loop is that\
if a single call fails, then the whole transaction is reverted which maybe undesirable. It's recommended\
to convert high level calls into low level calls so that we get a `bool success` instead of an automatic\
String::from("One of the dangers of having high level calls or an `address.transfer()` inside a loop is that \
if a single call fails, then the whole transaction is reverted which maybe undesirable. It's recommended \
to convert high level calls into low level calls so that we get a `bool success` instead of an automatic \
revert on failure.")
}

Expand Down
2 changes: 1 addition & 1 deletion reports/ccip-functions-report.md
Original file line number Diff line number Diff line change
Expand Up @@ -490,7 +490,7 @@ Solidity does initialize variables by default when you declare them, however it'

## H-4: Loop contains high level calls to other contracts and/or eth is transferred.

One of the dangers of having high level calls or an `address.transfer()` inside a loop is thatif a single call fails, then the whole transaction is reverted which maybe undesirable. It's recommendedto convert high level calls into low level calls so that we get a `bool success` instead of an automaticrevert on failure.
One of the dangers of having high level calls or an `address.transfer()` inside a loop is that if a single call fails, then the whole transaction is reverted which maybe undesirable. It's recommended to convert high level calls into low level calls so that we get a `bool success` instead of an automatic revert on failure.

<details><summary>10 Found Instances</summary>

Expand Down
2 changes: 1 addition & 1 deletion reports/report.json
Original file line number Diff line number Diff line change
Expand Up @@ -1801,7 +1801,7 @@
},
{
"title": "Loop contains high level calls to other contracts and/or eth is transferred.",
"description": "One of the dangers of having high level calls or an `address.transfer()` inside a loop is thatif a single call fails, then the whole transaction is reverted which maybe undesirable. It's recommendedto convert high level calls into low level calls so that we get a `bool success` instead of an automaticrevert on failure.",
"description": "One of the dangers of having high level calls or an `address.transfer()` inside a loop is that if a single call fails, then the whole transaction is reverted which maybe undesirable. It's recommended to convert high level calls into low level calls so that we get a `bool success` instead of an automatic revert on failure.",
"detector_name": "high-level-calls-in-loop",
"instances": [
{
Expand Down
2 changes: 1 addition & 1 deletion reports/report.md
Original file line number Diff line number Diff line change
Expand Up @@ -1792,7 +1792,7 @@ A deletion in a structure containing a mapping will not delete the mapping. The

## H-33: Loop contains high level calls to other contracts and/or eth is transferred.

One of the dangers of having high level calls or an `address.transfer()` inside a loop is thatif a single call fails, then the whole transaction is reverted which maybe undesirable. It's recommendedto convert high level calls into low level calls so that we get a `bool success` instead of an automaticrevert on failure.
One of the dangers of having high level calls or an `address.transfer()` inside a loop is that if a single call fails, then the whole transaction is reverted which maybe undesirable. It's recommended to convert high level calls into low level calls so that we get a `bool success` instead of an automatic revert on failure.

<details><summary>4 Found Instances</summary>

Expand Down
2 changes: 1 addition & 1 deletion reports/report.sarif
Original file line number Diff line number Diff line change
Expand Up @@ -2662,7 +2662,7 @@
}
],
"message": {
"text": "One of the dangers of having high level calls or an `address.transfer()` inside a loop is thatif a single call fails, then the whole transaction is reverted which maybe undesirable. It's recommendedto convert high level calls into low level calls so that we get a `bool success` instead of an automaticrevert on failure."
"text": "One of the dangers of having high level calls or an `address.transfer()` inside a loop is that if a single call fails, then the whole transaction is reverted which maybe undesirable. It's recommended to convert high level calls into low level calls so that we get a `bool success` instead of an automatic revert on failure."
},
"ruleId": "high-level-calls-in-loop"
},
Expand Down
2 changes: 1 addition & 1 deletion reports/sablier-aderyn-toml-nested-root.md
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ This report was generated by [Aderyn](https://github.com/Cyfrin/aderyn), a stati

## H-1: Loop contains high level calls to other contracts and/or eth is transferred.

One of the dangers of having high level calls or an `address.transfer()` inside a loop is thatif a single call fails, then the whole transaction is reverted which maybe undesirable. It's recommendedto convert high level calls into low level calls so that we get a `bool success` instead of an automaticrevert on failure.
One of the dangers of having high level calls or an `address.transfer()` inside a loop is that if a single call fails, then the whole transaction is reverted which maybe undesirable. It's recommended to convert high level calls into low level calls so that we get a `bool success` instead of an automatic revert on failure.

<details><summary>2 Found Instances</summary>

Expand Down
2 changes: 1 addition & 1 deletion reports/templegold-report.md
Original file line number Diff line number Diff line change
Expand Up @@ -525,7 +525,7 @@ A deletion in a structure containing a mapping will not delete the mapping. The

## H-9: Loop contains high level calls to other contracts and/or eth is transferred.

One of the dangers of having high level calls or an `address.transfer()` inside a loop is thatif a single call fails, then the whole transaction is reverted which maybe undesirable. It's recommendedto convert high level calls into low level calls so that we get a `bool success` instead of an automaticrevert on failure.
One of the dangers of having high level calls or an `address.transfer()` inside a loop is that if a single call fails, then the whole transaction is reverted which maybe undesirable. It's recommended to convert high level calls into low level calls so that we get a `bool success` instead of an automatic revert on failure.

<details><summary>17 Found Instances</summary>

Expand Down

0 comments on commit d03d555

Please sign in to comment.