Skip to content

Commit

Permalink
cli/reportgen
Browse files Browse the repository at this point in the history
  • Loading branch information
@TilakMaddy
TilakMaddy committed Aug 2, 2024
1 parent 28ade64 commit d6c8c09
Show file tree
Hide file tree
Showing 6 changed files with 2,175 additions and 14 deletions.
212 changes: 211 additions & 1 deletion reports/adhoc-sol-files-report.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ This report was generated by [Aderyn](https://github.com/Cyfrin/aderyn), a stati
- [L-14: Contract still has TODOs](#l-14-contract-still-has-todos)
- [L-15: Inconsistency in declaring uint256/uint (or) int256/int variables within a contract. Use explicit size declarations (uint256 or int256).](#l-15-inconsistency-in-declaring-uint256uint-or-int256int-variables-within-a-contract-use-explicit-size-declarations-uint256-or-int256)
- [L-16: Unused Custom Error](#l-16-unused-custom-error)
- [L-17: Potentially unused state variables found.](#l-17-potentially-unused-state-variables-found)


# Summary
Expand Down Expand Up @@ -72,7 +73,7 @@ This report was generated by [Aderyn](https://github.com/Cyfrin/aderyn), a stati
| Category | No. of Issues |
| --- | --- |
| High | 3 |
| Low | 16 |
| Low | 17 |


# High Issues
Expand Down Expand Up @@ -690,3 +691,212 @@ it is recommended that the definition be removed when custom error is unused



## L-17: Potentially unused state variables found.

State variable appears to be unused. No analysis has been performed to see if any inilne assembly references it. So if that's not the case, consider removing this unused variable.

<details><summary>33 Found Instances</summary>


- Found in InconsistentUints.sol [Line: 7](../tests/adhoc-sol-files/InconsistentUints.sol#L7)

```solidity
int public intVariable; // 1
```

- Found in InconsistentUints.sol [Line: 8](../tests/adhoc-sol-files/InconsistentUints.sol#L8)

```solidity
int256 public int256Variable; // 1
```

- Found in InconsistentUints.sol [Line: 15](../tests/adhoc-sol-files/InconsistentUints.sol#L15)

```solidity
uint[] public uintArray; // 4
```

- Found in InconsistentUints.sol [Line: 16](../tests/adhoc-sol-files/InconsistentUints.sol#L16)

```solidity
mapping(uint256 => uint other) u2uMapping; // 5 3
```

- Found in StateVariables.sol [Line: 8](../tests/adhoc-sol-files/StateVariables.sol#L8)

```solidity
uint256 private staticPrivateNumber;
```

- Found in StateVariables.sol [Line: 9](../tests/adhoc-sol-files/StateVariables.sol#L9)

```solidity
uint256 internal staticInternalNumber;
```

- Found in StateVariables.sol [Line: 10](../tests/adhoc-sol-files/StateVariables.sol#L10)

```solidity
uint256 public staticPublicNumber;
```

- Found in StateVariables.sol [Line: 13](../tests/adhoc-sol-files/StateVariables.sol#L13)

```solidity
uint256 private staticNonEmptyPrivateNumber = 1;
```

- Found in StateVariables.sol [Line: 14](../tests/adhoc-sol-files/StateVariables.sol#L14)

```solidity
uint256 internal staticNonEmptyInternalNumber = 2;
```

- Found in StateVariables.sol [Line: 15](../tests/adhoc-sol-files/StateVariables.sol#L15)

```solidity
uint256 public staticNonEmptyPublicNumber = 3;
```

- Found in StateVariables.sol [Line: 28](../tests/adhoc-sol-files/StateVariables.sol#L28)

```solidity
uint256 private constant PRIVATE_CONSTANT = 1;
```

- Found in StateVariables.sol [Line: 29](../tests/adhoc-sol-files/StateVariables.sol#L29)

```solidity
uint256 internal constant INTERNAL_CONSTANT = 2;
```

- Found in StateVariables.sol [Line: 30](../tests/adhoc-sol-files/StateVariables.sol#L30)

```solidity
uint256 public constant PUBLIC_CONSTANT = 3;
```

- Found in multiple-versions/0.4/A.sol [Line: 5](../tests/adhoc-sol-files/multiple-versions/0.4/A.sol#L5)

```solidity
address public constant MY_ADDRESS = address(0);
```

- Found in multiple-versions/0.4/A.sol [Line: 6](../tests/adhoc-sol-files/multiple-versions/0.4/A.sol#L6)

```solidity
uint256 public constant MY_UINT = 134131;
```

- Found in multiple-versions/0.4/B.sol [Line: 5](../tests/adhoc-sol-files/multiple-versions/0.4/B.sol#L5)

```solidity
address public MY_ADDRESS = address(0);
```

- Found in multiple-versions/0.4/B.sol [Line: 6](../tests/adhoc-sol-files/multiple-versions/0.4/B.sol#L6)

```solidity
uint256 public MY_UINT = 134131;
```

- Found in multiple-versions/0.5/A.sol [Line: 5](../tests/adhoc-sol-files/multiple-versions/0.5/A.sol#L5)

```solidity
address public constant MY_ADDRESS = address(0);
```

- Found in multiple-versions/0.5/A.sol [Line: 6](../tests/adhoc-sol-files/multiple-versions/0.5/A.sol#L6)

```solidity
uint256 public constant MY_UINT = 134131;
```

- Found in multiple-versions/0.5/B.sol [Line: 5](../tests/adhoc-sol-files/multiple-versions/0.5/B.sol#L5)

```solidity
address public MY_ADDRESS = address(0);
```

- Found in multiple-versions/0.5/B.sol [Line: 6](../tests/adhoc-sol-files/multiple-versions/0.5/B.sol#L6)

```solidity
uint256 public MY_UINT = 134131;
```

- Found in multiple-versions/0.6/A.sol [Line: 5](../tests/adhoc-sol-files/multiple-versions/0.6/A.sol#L5)

```solidity
address public constant MY_ADDRESS = address(0);
```

- Found in multiple-versions/0.6/A.sol [Line: 6](../tests/adhoc-sol-files/multiple-versions/0.6/A.sol#L6)

```solidity
uint256 public constant MY_UINT = 134131;
```

- Found in multiple-versions/0.6/B.sol [Line: 5](../tests/adhoc-sol-files/multiple-versions/0.6/B.sol#L5)

```solidity
address public MY_ADDRESS = address(0);
```

- Found in multiple-versions/0.6/B.sol [Line: 6](../tests/adhoc-sol-files/multiple-versions/0.6/B.sol#L6)

```solidity
uint256 public MY_UINT = 134131;
```

- Found in multiple-versions/0.7/A.sol [Line: 5](../tests/adhoc-sol-files/multiple-versions/0.7/A.sol#L5)

```solidity
address public constant MY_ADDRESS = address(0);
```

- Found in multiple-versions/0.7/A.sol [Line: 6](../tests/adhoc-sol-files/multiple-versions/0.7/A.sol#L6)

```solidity
uint256 public constant MY_UINT = 134131;
```

- Found in multiple-versions/0.7/B.sol [Line: 5](../tests/adhoc-sol-files/multiple-versions/0.7/B.sol#L5)

```solidity
address public MY_ADDRESS = address(0);
```

- Found in multiple-versions/0.7/B.sol [Line: 6](../tests/adhoc-sol-files/multiple-versions/0.7/B.sol#L6)

```solidity
uint256 public MY_UINT = 134131;
```

- Found in multiple-versions/0.8/A.sol [Line: 5](../tests/adhoc-sol-files/multiple-versions/0.8/A.sol#L5)

```solidity
address public constant MY_ADDRESS = address(0);
```

- Found in multiple-versions/0.8/A.sol [Line: 6](../tests/adhoc-sol-files/multiple-versions/0.8/A.sol#L6)

```solidity
uint256 public constant MY_UINT = 134131;
```

- Found in multiple-versions/0.8/B.sol [Line: 5](../tests/adhoc-sol-files/multiple-versions/0.8/B.sol#L5)

```solidity
address public MY_ADDRESS = address(0);
```

- Found in multiple-versions/0.8/B.sol [Line: 6](../tests/adhoc-sol-files/multiple-versions/0.8/B.sol#L6)

```solidity
uint256 public MY_UINT = 134131;
```

</details>



74 changes: 73 additions & 1 deletion reports/ccip-functions-report.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ This report was generated by [Aderyn](https://github.com/Cyfrin/aderyn), a stati
- [L-11: Contract still has TODOs](#l-11-contract-still-has-todos)
- [L-12: Unused Custom Error](#l-12-unused-custom-error)
- [L-13: Loop contains `require`/`revert` statements](#l-13-loop-contains-requirerevert-statements)
- [L-14: Potentially unused state variables found.](#l-14-potentially-unused-state-variables-found)


# Summary
Expand Down Expand Up @@ -101,7 +102,7 @@ This report was generated by [Aderyn](https://github.com/Cyfrin/aderyn), a stati
| Category | No. of Issues |
| --- | --- |
| High | 3 |
| Low | 13 |
| Low | 14 |


# High Issues
Expand Down Expand Up @@ -2450,3 +2451,74 @@ Avoid `require` / `revert` statements in a loop because a single bad item can ca



## L-14: Potentially unused state variables found.

State variable appears to be unused. No analysis has been performed to see if any inilne assembly references it. So if that's not the case, consider removing this unused variable.

<details><summary>10 Found Instances</summary>


- Found in src/v0.8/functions/dev/v1_X/FunctionsCoordinator.sol [Line: 19](../tests/ccip-contracts/contracts/src/v0.8/functions/dev/v1_X/FunctionsCoordinator.sol#L19)

```solidity
string public constant override typeAndVersion = "Functions Coordinator v1.3.0";
```

- Found in src/v0.8/functions/dev/v1_X/FunctionsRouter.sol [Line: 21](../tests/ccip-contracts/contracts/src/v0.8/functions/dev/v1_X/FunctionsRouter.sol#L21)

```solidity
string public constant override typeAndVersion = "Functions Router v2.0.0";
```

- Found in src/v0.8/functions/dev/v1_X/accessControl/TermsOfServiceAllowList.sol [Line: 19](../tests/ccip-contracts/contracts/src/v0.8/functions/dev/v1_X/accessControl/TermsOfServiceAllowList.sol#L19)

```solidity
string public constant override typeAndVersion = "Functions Terms of Service Allow List v1.1.0";
```

- Found in src/v0.8/functions/v1_0_0/FunctionsCoordinator.sol [Line: 19](../tests/ccip-contracts/contracts/src/v0.8/functions/v1_0_0/FunctionsCoordinator.sol#L19)

```solidity
string public constant override typeAndVersion = "Functions Coordinator v1.0.0";
```

- Found in src/v0.8/functions/v1_0_0/FunctionsRouter.sol [Line: 21](../tests/ccip-contracts/contracts/src/v0.8/functions/v1_0_0/FunctionsRouter.sol#L21)

```solidity
string public constant override typeAndVersion = "Functions Router v1.0.0";
```

- Found in src/v0.8/functions/v1_0_0/accessControl/TermsOfServiceAllowList.sol [Line: 19](../tests/ccip-contracts/contracts/src/v0.8/functions/v1_0_0/accessControl/TermsOfServiceAllowList.sol#L19)

```solidity
string public constant override typeAndVersion = "Functions Terms of Service Allow List v1.0.0";
```

- Found in src/v0.8/functions/v1_0_0/ocr/OCR2Base.sol [Line: 22](../tests/ccip-contracts/contracts/src/v0.8/functions/v1_0_0/ocr/OCR2Base.sol#L22)

```solidity
uint256 private constant maxUint32 = (1 << 32) - 1;
```

- Found in src/v0.8/functions/v1_1_0/FunctionsCoordinator.sol [Line: 19](../tests/ccip-contracts/contracts/src/v0.8/functions/v1_1_0/FunctionsCoordinator.sol#L19)

```solidity
string public constant override typeAndVersion = "Functions Coordinator v1.1.0";
```

- Found in src/v0.8/functions/v1_3_0/FunctionsCoordinator.sol [Line: 20](../tests/ccip-contracts/contracts/src/v0.8/functions/v1_3_0/FunctionsCoordinator.sol#L20)

```solidity
string public constant override typeAndVersion = "Functions Coordinator v1.3.0";
```

- Found in src/v0.8/functions/v1_3_0/accessControl/TermsOfServiceAllowList.sol [Line: 20](../tests/ccip-contracts/contracts/src/v0.8/functions/v1_3_0/accessControl/TermsOfServiceAllowList.sol#L20)

```solidity
string public constant override typeAndVersion = "Functions Terms of Service Allow List v1.1.0";
```

</details>



Loading

0 comments on commit d6c8c09

Please sign in to comment.