Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detector: Misused boolean #607

Merged
merged 15 commits into from
Jul 28, 2024
Merged

Detector: Misused boolean #607

merged 15 commits into from
Jul 28, 2024

Conversation

TilakMaddy
Copy link
Contributor

No description provided.

@TilakMaddy TilakMaddy marked this pull request as ready for review July 22, 2024 07:32
@TilakMaddy TilakMaddy requested a review from alexroan as a code owner July 22, 2024 07:32
@TilakMaddy
Copy link
Contributor Author

TilakMaddy commented Jul 23, 2024

I think we need to have some kind of reveal() method on our Expression nodes

Right now, there is no way to express the following without manually covering every case each time

"a constant boolean"

When I say that, I want to match with

  • Expression::Literal whose value is false/true
  • VariableDeclaration that is boolean type and constant
  • Expression::UnaryOperation with ! operator followed by a sub expression that could be either of the above

@TilakMaddy TilakMaddy marked this pull request as draft July 23, 2024 06:21
@alexroan
Copy link
Contributor

I think we need to have some kind of reveal() method on our Expression nodes

Is there a way we can do this with a helper or browser module @TilakMaddy ?

@TilakMaddy
Copy link
Contributor Author

I think we need to have some kind of reveal() method on our Expression nodes

Is there a way we can do this with a helper or browser module @TilakMaddy ?

Added to helper

@TilakMaddy TilakMaddy marked this pull request as ready for review July 26, 2024 13:58
@TilakMaddy
Copy link
Contributor Author

WAAAIIIT ! This workflow was running for 1hr 15 mins w/o my knowledge and I had to manually stop it ? That's bad. We need a timeout

Copy link
Contributor

@alexroan alexroan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@alexroan alexroan merged commit a9cccd8 into dev Jul 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants