Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove remappings from aderyn toml #826

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Remove remappings from aderyn toml #826

wants to merge 1 commit into from
+2 −21

Conversation

TilakMaddy
Copy link
Contributor

@TilakMaddy TilakMaddy commented Mar 10, 2025 •
edited
Loading

To make it less confusing, ask the users to write the remappings in remappings.txt. That should be enough.

Otherwise it's 3 places to manage

  • foundry.toml (if its a foundry project)
  • remappings.txt (sometimes soldeer can add extra stuff here)
  • aderyn.toml

3rd option we can eliminate. (We read from first 2 anyways using foundry config)

@TilakMaddy TilakMaddy marked this pull request as ready for review March 10, 2025 18:18
@TilakMaddy TilakMaddy requested a review from alexroan as a code owner March 10, 2025 18:18
@TilakMaddy TilakMaddy added the priority-high High priority Issue - Tackle this first. label Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexroan alexroan Awaiting requested review from alexroan alexroan is a code owner

Assignees
No one assigned
Labels
priority-high High priority Issue - Tackle this first.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@TilakMaddy