Update DSCEngineTest.t.sol - testCanRedeemCollateral() #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in the previous testCanRedeemCollateral() function it was being asserted that userBalance = amountCollateral `assertEq(userBalance, amountCollateral)` but that test is bound to fail because the `user` only had `amountCollateral = 10 ether` deposited as collateral and after calling the `dsce.redeemCollateral(weth, amountCollateral);` LOC there's not going to be any collateral left in the DSCEngine.
|
Hello @5hr1ganesh, Thanks for this contribution and this will be attended to appropriately as soon as possible. |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in the previous testCanRedeemCollateral() function it was being asserted that userBalance = amountCollateral
assertEq(userBalance, amountCollateral)but that test is bound to fail because theuseronly hadamountCollateral = 10 etherdeposited as collateral and after calling thedsce.redeemCollateral(weth, amountCollateral);LOC there's not going to be any collateral left in the DSCEngine. The modified test proves thatamountCollateralwas deposited and then redeemed.