Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the order of fields on the AdvancedSearch Page #209

Conversation

PaulBoon
Copy link

What this PR does / why we need it:
Have advanced search page use a query that orders by displayOrder before id, so that it will use the displayOrder if available instead of ignoring it.

Which issue(s) this PR closes:

Special notes for your reviewer:

Suggestions on how to test this:
Use a custom metadata block (tsv file) and change the order in a way that it is different from the rows order in the file, like change the last one to have order 0.
Then load that tsv and check the advanced search page, before the fix it would not be at the top, but after the fix it will be.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@PaulBoon PaulBoon closed this Feb 20, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build #136

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 22.736%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/edu/harvard/iq/dataverse/DatasetFieldServiceBean.java 0 1 0.0%
Totals Coverage Status
Change from base Build #135: 0.0%
Covered Lines: 19939
Relevant Lines: 87696

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Advanced search page does not use the display order of the metadata fields
2 participants