Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename patch new #336

Merged
merged 7 commits into from
Jan 4, 2024
Merged

Rename patch new #336

merged 7 commits into from
Jan 4, 2024

Conversation

d-chambers
Copy link
Contributor

Description

This PR renames patch.new to patch.update in order to be consistent with CoordinateManager.update, PatchAttributes.update and Coord.update. The documentation has also been updated accordingly.

However, to not break backwards compatibility, Patch.new still exists, and is a simple alias of Patch.update. It is just no longer advertised in the documentation.

I also added a few more examples to to_timedelta64 and to_datetime64 and tweaked one CSS parameter.

Checklist

I have (if applicable):

  • referenced the GitHub issue this PR closes.
  • documented the new feature with docstrings or appropriate doc page.
  • included a test. See testing guidelines.
  • your name has been added to the contributors page (docs/contributors.md).
  • added the "ready_for_review" tag once the PR is ready to be reviewed.

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a11438c) 99.52% compared to head (51a411e) 99.52%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #336   +/-   ##
=======================================
  Coverage   99.52%   99.52%           
=======================================
  Files          91       91           
  Lines        7191     7192    +1     
=======================================
+ Hits         7157     7158    +1     
  Misses         34       34           
Flag Coverage Δ
unittests 99.52% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@d-chambers d-chambers merged commit 8190ec7 into master Jan 4, 2024
15 checks passed
@d-chambers d-chambers deleted the rename_patch_new branch January 4, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant