Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples to support data registry entries #348

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

d-chambers
Copy link
Contributor

Description

This PR allows the get_example_spool and get_example_patch functions to support using the name of a data entry directly. E.g.,

import dascore as dc

patch = dc.get_example_patch("DASDMSShot00_20230328155653619.das") 

This PR also:

  • Adds the example data from the das4whales project to the data registry .
  • fixes a potential bug in the ProdML implementation where the attribute dims and coordinate manager dims could disagree.

Checklist

I have (if applicable):

  • referenced the GitHub issue this PR closes.
  • documented the new feature with docstrings or appropriate doc page.
  • included a test. See testing guidelines.
  • your name has been added to the contributors page (docs/contributors.md).
  • added the "ready_for_review" tag once the PR is ready to be reviewed.

@d-chambers d-chambers added the IO Work for reading/writing different formats label Mar 1, 2024
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.53%. Comparing base (8968e7f) to head (6be3fc0).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #348   +/-   ##
=======================================
  Coverage   99.53%   99.53%           
=======================================
  Files          91       91           
  Lines        7245     7250    +5     
=======================================
+ Hits         7211     7216    +5     
  Misses         34       34           
Flag Coverage Δ
unittests 99.53% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@d-chambers d-chambers merged commit e900f24 into master Mar 1, 2024
15 checks passed
@d-chambers d-chambers deleted the get_example_data_support branch March 1, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO Work for reading/writing different formats
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant