methods for size and range of coords #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmadtourei
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #356 +/- ##
=======================================
Coverage 99.53% 99.53%
=======================================
Files 94 94
Lines 7366 7384 +18
=======================================
+ Hits 7332 7350 +18
Misses 34 34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
d-chambers
approved these changes
Mar 27, 2024
| @@ -256,19 +256,19 @@ def test_size(self, coord_manager): | |||
| assert isinstance(coord_manager.size, int | np.int_) | |||
|
|
|||
| def test_min(self, basic_coord_manager): | |||
| """Ensure we can git min value.""" | |||
| """Ensure we can get min value.""" | |||
There was a problem hiding this comment.
Haha, thanks for fixing the typos along the way ;)
|
Thanks to @d-chambers for the valuable discussions and assistance with this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements methods for the CoordManager class to provide information such as number of channels, number of seconds, etc., about patch's coordinates.
Checklist
I have (if applicable):