Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ifft=False for whiten #361

Merged
merged 3 commits into from
Apr 9, 2024
Merged

ifft=False for whiten #361

merged 3 commits into from
Apr 9, 2024

Conversation

ahmadtourei
Copy link
Collaborator

@ahmadtourei ahmadtourei commented Apr 9, 2024 •
edited
Loading

Description

This PR makes whiten function capable of outputting in the frequency domain. This enhancement is particularly useful when whitening is performed as a preprocessing step for subsequent processes, such as computing cross-correlation.

Checklist

I have (if applicable):

  • referenced the GitHub issue this PR closes.
  • documented the new feature with docstrings or appropriate doc page.
  • included a test. See testing guidelines.
  • your name has been added to the contributors page (docs/contributors.md).
  • added the "ready_for_review" tag once the PR is ready to be reviewed.

@ahmadtourei ahmadtourei added ready_for_review PR is ready for review proc Related to processing module labels Apr 9, 2024
d-chambers
d-chambers approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@d-chambers d-chambers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ahmadtourei ahmadtourei merged commit 4330787 into master Apr 9, 2024
13 checks passed
@ahmadtourei ahmadtourei deleted the corr branch April 9, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-chambers d-chambers d-chambers approved these changes

Assignees
No one assigned
Labels
proc Related to processing module ready_for_review PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahmadtourei @d-chambers