Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Febus read, scan, and is_format support #369

Merged
merged 12 commits into from
May 2, 2024
Merged

Febus read, scan, and is_format support #369

merged 12 commits into from
May 2, 2024

Conversation

d-chambers
Copy link
Contributor

Description

This PR adds support for the Febus DAS format.

Checklist

I have (if applicable):

  • referenced the GitHub issue this PR closes.
  • documented the new feature with docstrings or appropriate doc page.
  • included a test. See testing guidelines.
  • your name has been added to the contributors page (docs/contributors.md).
  • added the "ready_for_review" tag once the PR is ready to be reviewed.

@d-chambers d-chambers added the IO Work for reading/writing different formats label Apr 30, 2024
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.53%. Comparing base (3b01269) to head (e6d4d29).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #369      +/-   ##
==========================================
+ Coverage   99.52%   99.53%   +0.01%     
==========================================
  Files          94       97       +3     
  Lines        7415     7596     +181     
==========================================
+ Hits         7380     7561     +181     
  Misses         35       35              
Flag Coverage Δ
unittests 99.53% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@d-chambers
Copy link
Contributor Author

I am going to merge this for now so we can do a quick release before the SSA das session tomorrow.

@d-chambers d-chambers merged commit 76d4583 into master May 2, 2024
15 checks passed
@d-chambers d-chambers deleted the febus branch May 2, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO Work for reading/writing different formats
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant