Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for python 3.13 #473

Merged
merged 9 commits into from
Dec 24, 2024
Merged

Add support for python 3.13 #473

merged 9 commits into from
Dec 24, 2024

Conversation

d-chambers
Copy link
Contributor

Description

This PR adds support for python 3.13. Although currently two of our optional dependencies don't support python 3.13 (numba and segyio). It should at least allow users to get most of DASCore's functionality until these libraries catch up. For now, we can just run py3.13 on the min_deps tests.

Also fixed a test to account for docstrings automatically having their white space stripped and added optional deps to the doc build since some docstrings will require them.

Checklist

I have (if applicable):

  • referenced the GitHub issue this PR closes.
  • documented the new feature with docstrings or appropriate doc page.
  • included a test. See testing guidelines.
  • your name has been added to the contributors page (docs/contributors.md).
  • added the "ready_for_review" tag once the PR is ready to be reviewed.

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.85%. Comparing base (df47d0e) to head (29824fd).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #473   +/-   ##
=======================================
  Coverage   99.85%   99.85%           
=======================================
  Files         115      115           
  Lines        9507     9507           
=======================================
  Hits         9493     9493           
  Misses         14       14           
Flag Coverage Δ
unittests 99.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@d-chambers d-chambers merged commit 2138fee into master Dec 24, 2024
18 checks passed
@d-chambers d-chambers deleted the py3.13 branch December 24, 2024 15:55
@d-chambers d-chambers mentioned this pull request Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant