Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump notifications-ruby-client from 5.4.0 to 6.2.0 #9618

Closed
wants to merge 1 commit into from
Closed

Bump notifications-ruby-client from 5.4.0 to 6.2.0 #9618

wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 1, 2024 •
edited
Loading

Bumps notifications-ruby-client from 5.4.0 to 6.2.0.

Changelog

Sourced from notifications-ruby-client's changelog.

6.2.0

  • Added fields related to cost data in response:
    • is_cost_data_ready: This field is true if cost data is ready, and false if it isn't (Boolean).
    • cost_in_pounds: Cost of the notification in pounds. The cost does not take free allowance into account (Float).
    • cost_details.billable_sms_fragments: Number of billable SMS fragments in your text message (SMS only) (Integer).
    • cost_details.international_rate_multiplier: For international SMS rate is multiplied by this value (SMS only) (Integer).
    • cost_details.sms_rate: Cost of 1 SMS fragment (SMS only) (Float).
    • cost_details.billable_sheets_of_paper: Number of sheets of paper in the letter you sent, that you will be charged for (letter only) (Integer).
    • cost_details.postage: Postage class of the notification sent (letter only) (String).

6.1.0

  • Adds a one_click_unsubscribe_url parameter to send_email so services can allow users to easily unsubscribe from distribution lists.
  • Adds a one_click_unsubscribe_url attribute to Notification class, so responses for get_notification include the unsubscribe link.

6.0.0

  • Removes the is_csv parameter from prepare_upload
  • Adds a filename parameter to prepare_upload to set the filename of the document upon download. See the documentation for more information.
Commits
  • b12fe69 Merge pull request #143 from alphagov/chore/joy/update-client
  • 072e18f chore: add changes to changelog
  • 2dd9265 chore: remove costdetails model
  • 2c15f89 fix: remove faulty cost_details test
  • 0c83509 chore: bump version
  • c1bcdf2 chore: update ruby client to include new fields: is_cost_data_ready, cost_in_...
  • dea03d6 Merge pull request #142 from alphagov/unsubscribe_link
  • 8bfc9ce Rename unsubscribe_link to one_click_unsubscribe_url
  • b7ceabc Version change
  • 6715c7f Add unsubscribe link to client arguments
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file Ruby Pull requests that update Ruby code labels Aug 1, 2024
@dcyoung-dev
Copy link
Collaborator

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/bundler/notifications-ruby-client-6.2.0 branch from 376681b to c509b60 Compare August 2, 2024 10:08
@dcyoung-dev
Copy link
Collaborator

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/bundler/notifications-ruby-client-6.2.0 branch from c509b60 to b2e1df4 Compare August 5, 2024 13:22
@dcyoung-dev
Copy link
Collaborator

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/bundler/notifications-ruby-client-6.2.0 branch from b2e1df4 to 0621dc1 Compare August 6, 2024 08:28
@dcyoung-dev
Copy link
Collaborator

[gems-node-modules 10/11] RUN bundle exec rake assets:precompile:
1.856 rake aborted!
1.864 LoadError: cannot load such file -- commonmarker/commonmarker (LoadError)
...
1.864 /usr/local/bundle/gems/openapi3_parser-0.10.0/lib/openapi3_parser.rb:4:in 'block in <top (required)>'
...
2.065 LoadError: Error relocating /usr/local/bundle/gems/commonmarker-1.1.5-aarch64-linux/lib/commonmarker/3.2/commonmarker.so: __snprintf_chk: symbol not found - /usr/local/bundle/gems/commonmarker-1.1.5-aarch64-linux/lib/commonmarker/3.2/commonmarker.so (LoadError)
...
2.065 /usr/local/bundle/gems/openapi3_parser-0.10.0/lib/openapi3_parser/markdown.rb:3:in `<top (required)>'

This PR is failing to build at the assets precompile stage with the above error.
I'm not sure how to fix this but I'm assuming it is connected to #9394 and causing all other dependabot PR issues

@tomas-stefano tomas-stefano force-pushed the dependabot/bundler/notifications-ruby-client-6.2.0 branch from 0621dc1 to 74898be Compare August 14, 2024 13:30
@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 14, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@tomas-stefano tomas-stefano reopened this Aug 14, 2024
@tomas-stefano tomas-stefano force-pushed the dependabot/bundler/notifications-ruby-client-6.2.0 branch from 74898be to a2e7311 Compare August 14, 2024 15:34
@inulty-dfe
Copy link
Collaborator

@dependabot recreate

@dependabot
Bump notifications-ruby-client from 5.4.0 to 6.2.0
8d63261 
Bumps [notifications-ruby-client](https://github.com/alphagov/notifications-ruby-client) from 5.4.0 to 6.2.0.
- [Changelog](https://github.com/alphagov/notifications-ruby-client/blob/main/CHANGELOG.md)
- [Commits](alphagov/notifications-ruby-client@5.4.0...6.2.0)

---
updated-dependencies:
- dependency-name: notifications-ruby-client
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/bundler/notifications-ruby-client-6.2.0 branch from a2e7311 to 8d63261 Compare October 11, 2024 11:42
@inulty-dfe
Copy link
Collaborator

Blocked by #9390

@elceebee elceebee self-assigned this Oct 24, 2024
@elceebee elceebee closed this Nov 5, 2024
@dependabot dependabot bot deleted the dependabot/bundler/notifications-ruby-client-6.2.0 branch November 5, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@elceebee elceebee

Labels
Blocked dependencies Pull requests that update a dependency file Ruby Pull requests that update Ruby code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dcyoung-dev @inulty-dfe @tomas-stefano @elceebee