chore: Resolve PR feedback

Author: WolfyUK

platform/src/apis/Platform.Api.LocalAuthorityFinances/Features/HighNeeds/Services/HighNeedsService.cs

@@ -124,7 +124,7 @@ public class HighNeedsService(IDatabaseFactory dbFactory) : HighNeedsStubService
         return results.ToArray();
     }
 
-    internal static LocalAuthority<Models.HighNeeds> MultiMapToHighNeeds(object[] objects)
+    private static LocalAuthority<Models.HighNeeds> MultiMapToHighNeeds(object[] objects)
     {
         var localAuthority = objects[0] as LocalAuthorityBase;
         var outturn = objects[1] as HighNeedsBase;

platform/src/apis/Platform.Api.LocalAuthorityFinances/Program.cs

@@ -1,10 +1,8 @@
 using System.Diagnostics.CodeAnalysis;
-using System.Runtime.CompilerServices;
 using Microsoft.Azure.Functions.Worker.Extensions.OpenApi.Extensions;
 using Microsoft.Extensions.Hosting;
 using Platform.Api.LocalAuthorityFinances.Configuration;
 
-[assembly: InternalsVisibleTo("Platform.LocalAuthorityFinances.Tests")]
 var hostBuilder = new HostBuilder()
     .ConfigureFunctionsWorkerDefaults(Worker.Configure, Worker.Options)
     .ConfigureServices(Services.Configure)

platform/tests/Platform.LocalAuthorityFinances.Tests/HighNeeds/Services/WhenHighNeedsServiceQueriesAsync.cs

@@ -63,7 +63,7 @@ public async Task ShouldQueryAndMultiMapWhenGetWithValidDimension()
     }
 
     [Fact]
-    public void ShouldMapWhenMultiMapToHighNeeds()
+    public async Task ShouldMapWhenMultiMapToHighNeeds()
     {
         var localAuthority = _fixture.Create<LocalAuthorityBase>();
         var outturn = _fixture.Create<HighNeedsBase>();
@@ -91,8 +91,27 @@ public void ShouldMapWhenMultiMapToHighNeeds()
             budgetPlaceFunding
         ];
 
+        // arrange
+        string[] codes = ["code1", "code2", "code3"];
+        const string dimension = "Actuals";
+        var results = _fixture
+            .Build<LocalAuthority<Api.LocalAuthorityFinances.Features.HighNeeds.Models.HighNeeds>>()
+            .CreateMany()
+            .ToArray();
+
+        Func<object[], LocalAuthority<Api.LocalAuthorityFinances.Features.HighNeeds.Models.HighNeeds>> mapper = _ => new LocalAuthority<Api.LocalAuthorityFinances.Features.HighNeeds.Models.HighNeeds>();
+        _connection
+            .Setup(c => c.QueryAsync(It.IsAny<PlatformQuery>(), It.IsAny<Type[]>(), It.IsAny<Func<object[], LocalAuthority<Api.LocalAuthorityFinances.Features.HighNeeds.Models.HighNeeds>>>(), It.IsAny<string[]>()))
+            .Callback<PlatformQuery, Type[], Func<object[], LocalAuthority<Api.LocalAuthorityFinances.Features.HighNeeds.Models.HighNeeds>>, string[]>((_, _, map, _) =>
+            {
+                mapper = map;
+            })
+            .ReturnsAsync(results);
+
+        await _service.Get(codes, dimension);
+
         // act
-        var actual = HighNeedsService.MultiMapToHighNeeds(objects);
+        var actual = mapper(objects);
 
         // assert
         Assert.Equal(localAuthority.Code, actual.Code);