Skip to content

Wire up HighNeedsService.Get() to underlying database views #2113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 14, 2025

Conversation

WolfyUK
Copy link
Collaborator

@WolfyUK WolfyUK commented Mar 14, 2025

Context

AB#253438 AB#252392

Change proposed in this pull request

  • Overrode stubbed version of the above service method
  • Used correct database view dependent on dimension using new PlatformQuery, with test coverage
  • Mapped result using Dapper multi mapping, with test coverage
  • Fixed typo in VW_LocalAuthorityFinancialPerPopulation

Guidance to review

  • Remaining stubbed service implementations with dependency on LA financials to be resolve as part of other work items.
  • E2E and API tests will be in a failing state until seed data added as part of other work items. These are currently excluded from pipeline runs anyway, so this change should not block upstream deployments.
  • Multi-mapping currently does not support CancellationToken. See QueryAsync with custom mapping AND CancellationToken DapperLib/Dapper#2125.

Checklist (add/remove as appropriate)

  • Work items have been linked (use AB#)
  • Your code builds clean without any errors or warnings
  • You have run all unit/integration tests and they pass
  • Your branch has been rebased onto main
  • You have tested by running locally
  • You have reviewed with UX/Design

WolfyUK added 2 commits March 14, 2025 07:52
…s override to stubbed version

Using Dapper multi mapping
@WolfyUK WolfyUK force-pushed the feature/253438/wire-up-la-financial branch from f48371d to 41273e5 Compare March 14, 2025 12:59
@WolfyUK WolfyUK merged commit 653b562 into main Mar 14, 2025
23 checks passed
@WolfyUK WolfyUK deleted the feature/253438/wire-up-la-financial branch March 14, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants