-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prometheus #148
Merged
Merged
Add prometheus #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e0b1417
to
abbf9d4
Compare
temitope777
reviewed
Jan 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is quite interesting @RMcVelia
good job
b6bc56c
to
3d34871
Compare
ca1776d
to
0ea4656
Compare
saliceti
reviewed
Jan 25, 2024
0ea4656
to
434fb5f
Compare
saliceti
reviewed
Jan 26, 2024
saliceti
reviewed
Jan 26, 2024
saliceti
reviewed
Jan 26, 2024
saliceti
reviewed
Jan 26, 2024
dbcb11f
to
8d047ef
Compare
8d047ef
to
ea71c0b
Compare
saliceti
approved these changes
Feb 2, 2024
ea71c0b
to
e2e0733
Compare
e2e0733
to
e333753
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Add prometheus monitoring for non-prod clusters
Currently scrapes below metrics
/metrics from the prometheus svc endpoint
/api/v1/nodes/${node}/proxy/metrics/cadvisor
/api/v1/nodes/${node}/proxy/metrics
/metrics from the prometheus api endpoint
had to disable tls verify for it to work.
May need to think about if we want all of these metrics.
Can check node api metrics via kubectl get --raw /api/v1/nodes/${node}/proxy/metrics or /proxy/metrics/cadvisor
Alert rules, scrape configs, etc will be improved in later PR's.
Changes proposed in this pull request
Add required terraform resources
Add initial doc
Guidance to review
make development terraform-plan ENVIRONMENT=cluster6
scripts/pfwd.sh
http://localhost:8080/
Before merging
Remove "--storage.tsdb.retention.time=12h" from the prometheus deployment
Checklist
Devops
label