Thanos fixes #161
Merged
Thanos fixes #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saliceti
reviewed
Feb 19, 2024
| @@ -176,4 +176,9 @@ locals { | |||
| storage-account-name = azurerm_storage_account.thanos.name | |||
| storage-account-key = azurerm_storage_account.thanos.primary_access_key | |||
| } | |||
|
|
|||
| cluster_sa_name = (var.cluster_short != "dv" ? | |||
There was a problem hiding this comment.
Can we avoid hardcording the environment name?
Maybe compare environment and config as in https://github.com/DFE-Digital/teacher-services-cloud/blob/main/cluster/terraform_kubernetes/variables.tf#L132
There was a problem hiding this comment.
updated as suggested
RMcVelia
force-pushed
the
thanos-fixes
branch
from
28c8ba9 to
ff4d6db
Compare
saliceti
approved these changes
Feb 19, 2024
RMcVelia
force-pushed
the
thanos-fixes
branch
from
7039e18 to
83814ef
Compare
We don't need to label by replica as it's a single prometheus Prometheus service should be clusterip not nodeport Thanos store gateway is a headless service
RMcVelia
force-pushed
the
thanos-fixes
branch
from
83814ef to
f28d711
Compare
saliceti
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Thanos fixes
Changes proposed in this pull request
I couldn't find out why it suddenly started occurring, so have added a dependency in terraform.
e.g.
│ Error: Failed to create deployment: namespaces "monitoring" not found
│
│ with kubernetes_deployment.thanos-compactor,
│ on thanos.tf line 247, in resource "kubernetes_deployment" "thanos-compactor":
│ 247: resource "kubernetes_deployment" "thanos-compactor" {
│
│ Error: Failed to create deployment: namespaces "infra" not found
│
│ with kubernetes_deployment.welcome_app[0],
│ on welcome_app.tf line 1, in resource "kubernetes_deployment" "welcome_app":
│ 1: resource "kubernetes_deployment" "welcome_app" {
│
updated the dev cluster thanos storage account name, as it was using the same name for all 6 dev clusters.
changes to allow the querier to see the store correctly
Guidance to review
make development terraform-apply ENVIRONMENT=clusterx
make platform-test terraform-plan (shouldn't see any changes)
scripts/pfwd.sh
http://localhost:8082
checking the stores, should see the sidecar and the store
Checklist
Devopslabel