Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1604 create grafana service #168

Merged
merged 1 commit into from
Feb 29, 2024
Merged

1604 create grafana service #168

merged 1 commit into from
Feb 29, 2024

Conversation

johnake
Copy link
Contributor

@johnake johnake commented Feb 26, 2024 •
edited
Loading

Context

Create grafana service

Changes proposed in this pull request

  • Create grafana service
  • Apply change to dev(cluster 6) and platform test
  • Create admin username and password and then save in keyvault

Guidance to review

  • Pull this branch to your local
  • Connect to the applicable cluster using kubectl
  • Set up port forwarding using [kubectl -n monitoring port-forward service/grafana 3000:3000] - to test the grafana UI locally

https://trello.com/c/BgdHzhHE/1604-create-grafana-service

Checklist

  • I have performed a self-review of my code, including formatting and typos
  • I have cleaned the commit history
  • I have added the Devops label
  • I have attached the pull request to the trello card

@johnake johnake force-pushed the 1604-create-grafana-service branch from cffa048 to 98a7578 Compare February 26, 2024 11:27
@johnake johnake added the DevOps label Feb 26, 2024
@johnake
Copy link
Contributor Author

johnake commented Feb 26, 2024

Create grafana service

RMcVelia
RMcVelia reviewed Feb 26, 2024
View reviewed changes
Copy link
Collaborator

@RMcVelia RMcVelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also update the monitoring readme doc

@RMcVelia
Copy link
Collaborator

Please also update scripts/pfwd.sh so it can do the port forwarding for grafana

@johnake johnake force-pushed the 1604-create-grafana-service branch from 98a7578 to e83b4d1 Compare February 27, 2024 09:20
@johnake johnake force-pushed the 1604-create-grafana-service branch from e83b4d1 to 287fe9a Compare February 28, 2024 09:17
@johnake johnake force-pushed the 1604-create-grafana-service branch from 287fe9a to 8ca0b32 Compare February 29, 2024 10:41
@johnake johnake merged commit 572bf58 into main Feb 29, 2024
4 checks passed
@johnake johnake deleted the 1604-create-grafana-service branch February 29, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RMcVelia RMcVelia RMcVelia approved these changes

Assignees
No one assigned
Labels
DevOps
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnake @RMcVelia