Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2203] Template external url #348

Merged
merged 3 commits into from
Jan 14, 2025
Merged

[2203] Template external url #348

merged 3 commits into from
Jan 14, 2025

Conversation

saliceti
Copy link
Member

@saliceti saliceti commented Jan 13, 2025 •
edited
Loading

Context

Provide explicit apex URL for SSL monitoring

Changes proposed in this pull request

  • Introduce apex_url terraform variable
  • Remove EXTERNAL_URL environment variable
  • Refactor applciation_configuration module to use config_variables_path

Guidance to review

Checklist

  • I have performed a self-review of my code, including formatting and typos
  • I have cleaned the commit history
  • I have added the Devops label
  • I have attached the pull request to the trello card

@saliceti
Introduce apex_url variable in template
8456de7 
Explicit variable for SSL certificate monitoring
@saliceti
Remove template EXTERNAL_URL variable yml
a54dca1 
The yaml file is for application environment variables and there is
already a var.external_url input variable
@saliceti
Use application_configuration config_variables_path
075787e 
The template should use this argument instead of recreating the logic
@saliceti saliceti merged commit a0c18ed into main Jan 14, 2025
6 checks passed
@saliceti saliceti deleted the 2203-amend-template-external-url branch January 14, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RMcVelia RMcVelia RMcVelia approved these changes

Assignees
No one assigned
Labels
DevOps
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saliceti @RMcVelia