Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alertmanager config reloader container #352

Merged
merged 3 commits into from
Jan 15, 2025

Conversation

shaheislamdfe
Copy link
Contributor

@shaheislamdfe shaheislamdfe commented Jan 15, 2025

Context

Adding reloader to the cluster with Terraform resources

Changes proposed in this pull request

Adding reloader to the cluster with Terraform resources

Guidance to review

Change a config map when the annotation for reloader is applied and watch the deployment dynamically restart

Screenshot 2025-01-15 at 14 31 11

Checklist

  • I have performed a self-review of my code, including formatting and typos
  • I have cleaned the commit history
  • I have added the Devops label
  • I have attached the pull request to the trello card

feat: Changing to reference container image
@shaheislamdfe shaheislamdfe force-pushed the 1715-alertmanager-config-reloader-container branch from ec051f2 to 7738929 Compare January 15, 2025 14:32
Copy link
Contributor

@vipin-dfe vipin-dfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@shaheislamdfe shaheislamdfe merged commit 4a42bbf into main Jan 15, 2025
3 checks passed
@shaheislamdfe shaheislamdfe deleted the 1715-alertmanager-config-reloader-container branch January 15, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants