Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dev cluster env to ga_wif naming #355

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

RMcVelia
Copy link
Collaborator

Context

ga_wif naming doesn't include the dev cluster env, so cluster build fails if one already exists

Error: A resource with the ID "/subscriptions/nnnnnnn/resourceGroups/s189d01-tsc-dv-rg/providers/Microsoft.ManagedIdentity/userAssignedIdentities/s189d01-ga-wif-development-bat-id" already exists - to be managed via Terraform this resource needs to be imported into the State. Please see the resource documentation for "azurerm_user_assigned_identity" for more information.

Changes proposed in this pull request

use var.environment instead of var.config
this will create s189d01-ga-wif-clustern-bat-id instead of s189d01-ga-wif-development-bat-id

Guidance to review

see dev cluster 1
make env deploy-plan makes no changes to test, production clusters

Checklist

  • I have performed a self-review of my code, including formatting and typos
  • I have cleaned the commit history
  • I have added the Devops label
  • I have attached the pull request to the trello card

@RMcVelia RMcVelia merged commit 19ff3c8 into main Jan 16, 2025
6 checks passed
@RMcVelia RMcVelia deleted the fix-ga-wif-name-for-dev-clusters branch January 16, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants