CI-CD for domains #356
Merged
CI-CD for domains #356
+113
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RMcVelia
reviewed
Jan 20, 2025
neillturner
force-pushed
the
ci-cd-domains
branch
2 times, most recently
from
338f78e to
52cfb82
Compare
RMcVelia
approved these changes
Jan 21, 2025
neillturner
force-pushed
the
ci-cd-domains
branch
from
52cfb82 to
cb19a92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
adding workflows for domain deployment to build workflows
Changes proposed in this pull request
this is the updated template for build_and_deploy.yml adding calls to the deploy domains github actions.
Guidance to review
review the actions to see the workflows being running.
review code and decide on best architecture
can see test runs for jobs added to build_and_deploy.yml run as separate test runs but doing plan not apply
https://github.com/DFE-Digital/itt-mentor-services/actions/runs/12829975027
https://github.com/DFE-Digital/itt-mentor-services/actions/runs/12829975022 (this only fails because plan doesn't see output variable like apply so will success for appply)
Link to Trello card
Implement CI/CD for domains on all services
Checklist
Devopslabel