Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0] fix: make 2 methods of WorkflowTaskAgent extendable #8019

Merged
merged 1 commit into from
Feb 3, 2025
Merged

[8.0] fix: make 2 methods of WorkflowTaskAgent extendable #8019

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/DIRAC/TransformationSystem/Client/WorkflowTasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,11 +112,11 @@ def prepareTransformationTasks(
ownerDN = res["Value"][0]

if bulkSubmissionFlag:
return self.__prepareTasksBulk(transBody, taskDict, owner, ownerGroup, ownerDN)
return self._prepareTasksBulk(transBody, taskDict, owner, ownerGroup, ownerDN)
# not a bulk submission
return self.__prepareTasks(transBody, taskDict, owner, ownerGroup, ownerDN)
return self._prepareTasks(transBody, taskDict, owner, ownerGroup, ownerDN)

def __prepareTasksBulk(self, transBody, taskDict, owner, ownerGroup, ownerDN):
def _prepareTasksBulk(self, transBody, taskDict, owner, ownerGroup, ownerDN):
"""Prepare transformation tasks with a single job object for bulk submission

:param str transBody: transformation job template
Expand All @@ -132,7 +132,7 @@ def __prepareTasksBulk(self, transBody, taskDict, owner, ownerGroup, ownerDN):
else:
return S_OK({})

method = "__prepareTasksBulk"
method = "_prepareTasksBulk"
startTime = time.time()

# Prepare the bulk Job object with common parameters
Expand Down Expand Up @@ -257,7 +257,7 @@ def __prepareTasksBulk(self, transBody, taskDict, owner, ownerGroup, ownerDN):
taskDict["BulkJobObject"] = oJob
return S_OK(taskDict)

def __prepareTasks(self, transBody, taskDict, owner, ownerGroup, ownerDN):
def _prepareTasks(self, transBody, taskDict, owner, ownerGroup, ownerDN):
"""Prepare transformation tasks with a job object per task

:param str transBody: transformation job template
Expand All @@ -273,7 +273,7 @@ def __prepareTasks(self, transBody, taskDict, owner, ownerGroup, ownerDN):
else:
return S_OK({})

method = "__prepareTasks"
method = "_prepareTasks"
startTime = time.time()

oJobTemplate = self.jobClass(transBody)
Expand Down
Loading