Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0] updating the mysql version used in the tests #8039

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

fstagni
Copy link
Contributor

@fstagni fstagni commented Feb 10, 2025

From 8.0 to 8.4

From https://dev.mysql.com/doc/refman/8.4/en/mysql-nutshell.html :

Nonstandard foreign keys. The use of non-unique or partial keys as foreign keys is nonstandard, and is deprecated in MySQL. Beginning with MySQL 8.4.0, you must explicitly enable such keys by setting restrict_fk_on_non_standard_key to OFF, or by starting the server with --skip-restrict-fk-on-non-standard-key.

ALTER TABLE Tasks DROP PRIMARY KEY, ADD PRIMARY KEY (`TaskID`);
ALTER TABLE CacheReplicas DROP PRIMARY KEY, ADD PRIMARY KEY (`ReplicaID`);

BEGINRELEASENOTES

*Subsystem
CHANGE: default MySQL version from 8.0 to 8.4

ENDRELEASENOTES

@DIRACGridBot DIRACGridBot added the alsoTargeting:integration Cherry pick this PR to integration after merge label Feb 10, 2025
@fstagni fstagni force-pushed the 80_mysql_version_update branch from be53eab to 1325d54 Compare February 10, 2025 17:05
@fstagni fstagni marked this pull request as ready for review February 11, 2025 08:21
@chaen
Copy link
Contributor

chaen commented Feb 12, 2025

why do we need these index changes ? 🤔

@fstagni fstagni merged commit 50d498d into DIRACGrid:rel-v8r0 Feb 12, 2025
26 checks passed
@DIRACGridBot DIRACGridBot added sweep:done All sweeping actions have been done for this PR sweep:failed Sweeping failed and needs manual intervention labels Feb 12, 2025
@DIRACGridBot
Copy link

Sweep summary

Sweep ran in https://github.com/DIRACGrid/DIRAC/actions/runs/13286343760

Failed:

  • integration
    cherry-pick 50d498d into integration failed
    check merge conflicts on a local copy of this repository
    git fetch upstream
    git checkout upstream/integration -b cherry-pick-2-50d498d76-integration
    git cherry-pick -x -m 1 50d498d76
    # Fix the conflicts
    git cherry-pick --continue
    git commit --amend -m 'sweep: #8039 updating the mysql version used in the tests' --author='Federico Stagni <federico.stagni@cern.ch>'
    git push -u origin cherry-pick-2-50d498d76-integration
    
    # If you have the GitHub CLI installed the PR can be made with
    gh pr create \
         --label 'sweep:from rel-v8r0' \
         --base integration \
         --repo DIRACGrid/DIRAC \
         --title '[sweep:integration] updating the mysql version used in the tests' \
         --body 'Sweep #8039 `updating the mysql version used in the tests` to `integration`.
    
    Adding original author @fstagni as watcher.
    
    BEGINRELEASENOTES
    
    *Subsystem
    CHANGE: default MySQL version from 8.0 to 8.4
    
    ENDRELEASENOTES
    Closes #8043'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alsoTargeting:integration Cherry pick this PR to integration after merge sweep:done All sweeping actions have been done for this PR sweep:failed Sweeping failed and needs manual intervention
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants