test: bandit CI #225
Merged
test: bandit CI #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaen
force-pushed
the
bandit
branch
2 times, most recently
from
f11c013 to
4a5c7d7
Compare
chaen
force-pushed
the
bandit
branch
2 times, most recently
from
c83af45 to
3eacc96
Compare
chrisburr
reviewed
Mar 26, 2024
| @@ -73,7 +73,7 @@ class GrantType(StrEnum): | |||
|
|
|||
| authorization_code = "authorization_code" | |||
| device_code = "urn:ietf:params:oauth:grant-type:device_code" | |||
| refresh_token = "refresh_token" | |||
| refresh_token = "refresh_token" # noqa: S105 # False positif of Bandit about hard coded password | |||
There was a problem hiding this comment.
either fix the typo or remove the comment
Suggested change
| refresh_token = "refresh_token" # noqa: S105 # False positif of Bandit about hard coded password | |
| refresh_token = "refresh_token" # noqa: S105 |
chrisburr
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the Bandit check in
ruff.These are basically best practices to avoid obvious security loophole. It comes with quite some false positive, but it is better than false negative when it comes to security :-)