Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override Rollup in Vite to use @rollup/wasm-node for platform independence #2950

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

nicholas-ly
Copy link
Contributor

Description

Added an override in package.json to replace the native Rollup build with the platform-independent @rollup/wasm-node version for Vite, which ensures compatibility across different platforms and architectures.

Screenshots (if applicable)

image

Checklist

  • I have tested the changes locally
  • I have updated the documentation if necessary
  • I have checked that my code follows the project's coding style by running npm run format:check
  • I have checked that my code contains no linting errors by running npm run lint
  • I have checked that my code contains no type errors by running npm run typecheck
  • I have checked that all unit tests pass by running npm run test:unit -- run
  • I have checked that all e2e tests pass by running npm run test:e2e

Additional Notes

Based off DTS-STN/future-sir#71

@nicholas-ly nicholas-ly enabled auto-merge (squash) January 14, 2025 16:40
@nicholas-ly nicholas-ly merged commit 56c850d into main Jan 14, 2025
6 checks passed
@nicholas-ly nicholas-ly deleted the nick/vite-rollup branch January 14, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants