WiFi Over the air update #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottyob
force-pushed
the
ota
branch
2 times, most recently
from
3a35761 to
6e75b74
Compare
oxothnk423
reviewed
Dec 24, 2024
| @@ -20,6 +20,14 @@ board_build.partitions = default_8MB.csv | |||
|
|
|||
| lib_extra_dirs = src/libraries | |||
|
|
|||
| lib_deps = | |||
There was a problem hiding this comment.
Just starting to test out the OTA functionality! Noticed new libraries required; would be great to include these in the readme file for Arduino users as well
https://github.com/scottyob/leaf/tree/ota/src/vario#required-libraries
src/vario/PageQR.cpp
Outdated
| #include "PageQR.h" | ||
|
|
||
| #include "display.h" | ||
| #include "qrcode.h" |
There was a problem hiding this comment.
This include doesn't seem to work when building in Arduino. ("QRCode was not declared in this scope")
Quick research suggests it may be because of a conflict with built in ESP32 board package (also has a qrcode.h). See here:
ricmoo/QRCode#31
Suggestions on best way to handle?
…k of modal page drawing
Not required for PlatformIO, but this adds support for Arduino IDE builds once the etlcpp library has been added. Test Plan (using Arduino IDE): ``` Sketch uses 612976 bytes (46%) of program storage space. Maximum is 1310720 bytes. Global variables use 91304 bytes (27%) of dynamic memory, leaving 236376 bytes for local variables. Maximum is 327680 bytes. ```
Added a build flag to PlatformIO to know when we're building with that. Added a new library to the Arduino github action so it can check out that library.. I still maintain that keeping this working in two build environments is making this project harder to maintain already :\
QR Code library was not building with Arduino. Followed the recommended approach to copy/paste it in and rename it. It appears to be MIT license, so I think this is good.
* BugFix that may cause exception faults on two pages sharing no sub-menus * Added WiFi Manager to be able to configure WiFi without the needed for an app under "Manual" mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Plan:
IMG_2765.1.mp4