Drop Arduino Support #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arduino support means we can't re-factor code to be in sub-directories and is adding in too much friction. As this project has outgrown it, let's drop it in favor of PlatformIO. Will need issue to clean up documentation.
|
I'm not particularly opposed to dropping Arduino IDE support, but I think it's pretty important to keep the repo as error-free as practical. If this PR were merged as-is, I think we would be increasing tech debt (adding errors to the repo) since, e.g., at least the following content would be made incorrect:
I would suggest either including the changes necessary to keep the repo consistent in this PR, or make them in a separate PR prior to this one. |
|
I think before a big release we can focus on the doco. Leave it to y'll if/how/when you want to merge this work in. |
|
This seems to have been added with a push. Will get better at making stacked branches more obvious, promise! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arduino support means we can't re-factor code to be in sub-directories and is adding in too much friction. As this project has outgrown it, let's drop it in favor of PlatformIO.
Will need issue to clean up documentation.