Add IOexpander #90
Merged
Add IOexpander #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
putting speaker updated on main timer (instead of it's own ISR) avoids I2C conflicts with other peripherals I2C expander added and supported in variants
scottyob
requested changes
Mar 6, 2025
| void ioexDigitalWrite(bool onIOEX, uint8_t pin, uint8_t value) { | ||
| // if we're writing a pin on the IO Expander | ||
| if (onIOEX) { | ||
| bool result = IOEX.write1(pin, value); |
There was a problem hiding this comment.
Remove result if not doing anything with it.
There was a problem hiding this comment.
redundant lib files removed; thanks for reminder!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for IOexpander in variants (HW v3.2.5+ has IOexpander)
Moved speaker updates to main system timer (instead of its own ISR timer). This avoids simultaneous I2C calls and conflicts. (I2C needed to set volume pins for speaker on HW v3.2.5)