Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enhance Lock Period Logic and Improve Test Coverage for SharingWishVault Contract #41

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

0x-stan
Copy link
Contributor

@0x-stan 0x-stan commented Feb 27, 2025

主要修改:

锁定期逻辑增强:

  • 修复了合约中与锁定期相关的逻辑,确保在锁定期内的操作(如捐款、结算和索赔)符合预期。
  • 添加了更严格的检查,以防止在锁定期过期后进行不当操作。

测试用例更新:

  • 更新了 SharingWishVault.test.js 中的测试用例,以确保它们与新的合约逻辑一致。
  • 添加了对锁定期逻辑的全面测试,确保在不同情况下的行为正确。

代码清理:

  • 统一了错误消息的格式,确保代码的一致性和可读性。

影响:

  • 这些修改提高了合约的安全性和可靠性,确保用户在使用合约时不会遇到意外的行为。
  • 测试覆盖率得到了显著提升,确保了合约在各种情况下的正确性。

Merge donor test cases into SharingWishVault.test.js

- Added donor tracking and proportional withdrawal tests to the main test file.
- Included new signer (david) for testing.
- Removed the separate donor test file for better organization.
- Ensured all tests pass successfully.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant