Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why override PEP 8 defined line lenght? #84

Open
pietrushnic opened this issue Dec 28, 2024 · 1 comment
Open

Why override PEP 8 defined line lenght? #84

pietrushnic opened this issue Dec 28, 2024 · 1 comment
Assignees

Comments

@pietrushnic
Copy link
Contributor

Many TODOs in .robotcop.toml are used in this repo. We override the line length to 180, which we should not do.

Can PR, which will fix that, revert that override? Are we expecting someone to do it for the whole code in one run?

First PR which try to address the issue: https://github.com/Dasharo/osfv-scripts/pull/81/files

@macpijan
Copy link
Contributor

macpijan commented Feb 14, 2025

Many TODOs in .robotcop.toml are used in this repo. We override the line length to 180, which we should not do.
Can PR, which will fix that, revert that override? Are we expecting someone to do it for the whole code in one run?

This is copied from OSFV, where application of such strict rules blows everything apart. Here we have much less RF code and probably would not be a problem, but we might as well keep the consistent rules.

Your PR addresses the Python length, which is fine to change. For some reason, black Python formatter uses different default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants